Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate kubernetes/cluster-api-provider-azure jobs to eks cluster #29755

Merged
merged 1 commit into from
Jun 27, 2023
Merged

migrate kubernetes/cluster-api-provider-azure jobs to eks cluster #29755

merged 1 commit into from
Jun 27, 2023

Conversation

iftachk
Copy link
Contributor

@iftachk iftachk commented Jun 10, 2023

jobs: migrate kubernetes/cluster-api-provider-azure jobs to eks cluster

  • Add missing resource blocks

/priority important-longterm
/area jobs

Part of #29722

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @iftachk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from Jont828 and nojnhuh June 10, 2023 05:04
@rjsadow rjsadow mentioned this pull request Jun 10, 2023
Closed
54 tasks
@rjsadow
Copy link
Contributor

rjsadow commented Jun 11, 2023

It looks like most of the requests added previously were 2cpu/9Gb, I would recommend making that the default for the rest of these.

cc @Jont828 @nawazkh @nojnhuh

@rjsadow
Copy link
Contributor

rjsadow commented Jun 12, 2023

@iftachk, based on #29722 (comment), we'll need to revert the changes for:

  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-e2e-optional
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-capi-e2e
  • pull-cluster-api-provider-azure-conformance
  • pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
  • pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow
  • pull-cluster-api-provider-azure-e2e-workload-upgrade
  • pull-cluster-api-provider-azure-apiversion-upgrade
  • pull-cluster-api-provider-azure-ci-entrypoint
  • pull-cluster-api-provider-azure-e2e-v1beta1
  • pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
  • pull-cluster-api-provider-azure-e2e-optional-v1beta1
  • pull-cluster-api-provider-azure-e2e-windows-dockershim-v1beta1
  • pull-cluster-api-provider-azure-e2e-aks-v1beta1
  • pull-cluster-api-provider-azure-capi-e2e-v1beta1
  • pull-cluster-api-provider-azure-conformance-v1beta1
  • pull-cluster-api-provider-azure-ci-entrypoint-v1beta1
  • pull-cluster-api-provider-azure-conformance-with-ci-artifacts-v1beta1
  • pull-cluster-api-provider-azure-conformance-with-ci-artifacts-v1beta1

CecileRobertMichon
CecileRobertMichon suggested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can't migrate any of the jobs that depend on preset-azure-cred-only currently as those need the GCP secrets to authenticate to create Azure resources. Only the "build" and "test" jobs can be migrated for now

Identify your CI jobs that do not depend on external cloud assets, for example unit test, linting, build. Jobs that e.g. create external GCP e2e clusters are not good candidates at this time as we're focusing on migrating

https://groups.google.com/a/kubernetes.io/g/dev/c/H5-G2bQGgds

@iftachk
Copy link
Contributor Author

iftachk commented Jun 14, 2023

@rjsadow @CecileRobertMichon
After reviewing the initial comment, I have come up with the following list of jobs that will be migrated:

  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-verify
  • pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow
  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-test-v1beta1
  • pull-cluster-api-provider-azure-build-v1beta1
  • pull-cluster-api-provider-azure-verify-v1beta1
  • pull-cluster-api-provider-azure-apidiff-v1beta1

These are not only build or test jobs, but none of them have the preset-azure-cred-only label

Please let me know if that list works for you

@CecileRobertMichon
Copy link
Member

@iftachk everything in that list is good except pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow, that one creates Azure resources that depend on credentials from preset-azure-cred-only

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 16, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: iftachk / name: Iftach Konshtok (19c1250)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 16, 2023
@iftachk iftachk force-pushed the migrate-cluster-api-provider-azure-jobs branch from 5e728af to b6cf2bf Compare June 16, 2023 17:50
@rjsadow
Copy link
Contributor

rjsadow commented Jun 18, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2023
@iftachk
jobs: migrate kubernetes/cluster-api-provider-azure jobs to eks cluster
19c1250 
- Add missing resource blocks
- exclude jobs with `preset-azure-creds-only` label

Signed-off-by: Iftach Konshtok <[email protected]>
@iftachk iftachk force-pushed the migrate-cluster-api-provider-azure-jobs branch from b6cf2bf to 19c1250 Compare June 20, 2023 15:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@iftachk
Copy link
Contributor Author

iftachk commented Jun 20, 2023

@CecileRobertMichon, the PR has been updated.
Would appreciate your feedback and approval, in case it looks good to you.
Thanks,
cc @rjsadow @ameukam

CecileRobertMichon
CecileRobertMichon reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @jackfrancis

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@jackfrancis
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iftachk, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2d3c5ce into kubernetes:master Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

@iftachk: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
  • key cluster-api-provider-azure-presubmits-release-v1beta1.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-v1beta1.yaml

In response to this:

jobs: migrate kubernetes/cluster-api-provider-azure jobs to eks cluster

  • Add missing resource blocks

/priority important-longterm
/area jobs

Part of #29722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjsadow rjsadow rjsadow left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon requested changes

@ameukam ameukam ameukam left review comments

@Jont828 Jont828 Awaiting requested review from Jont828

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@jackfrancis jackfrancis

@CecileRobertMichon CecileRobertMichon

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iftachk @k8s-ci-robot @rjsadow @CecileRobertMichon @jackfrancis @ameukam