Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate kubernetes/image-builder jobs to eks cluster #29752

Merged
merged 1 commit into from
Jun 20, 2023
Merged

migrate kubernetes/image-builder jobs to eks cluster #29752

merged 1 commit into from
Jun 20, 2023

Conversation

iftachk
Copy link
Contributor

@iftachk iftachk commented Jun 10, 2023

jobs: migrate kubernetes/image-builder jobs to eks cluster

  • Add missing resource blocks

/priority important-longterm
/area jobs

Part of #29722

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @iftachk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and wojtek-t June 10, 2023 04:35
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 10, 2023
@rjsadow rjsadow mentioned this pull request Jun 10, 2023
Closed
54 tasks
rjsadow
rjsadow reviewed Jun 11, 2023
View reviewed changes
Copy link
Contributor

@rjsadow rjsadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, the checks will fail without cpu and memory resource definitions though. Thanks @iftachk!

config/jobs/kubernetes-sigs/image-builder/image-builder-ova-presubmits.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes-sigs/image-builder/image-builder-presubmits.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes-sigs/image-builder/image-builder-presubmits.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes-sigs/image-builder/image-builder-presubmits.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes-sigs/image-builder/image-builder-presubmits.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Jun 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2023
@iftachk
Copy link
Contributor Author

iftachk commented Jun 11, 2023

/retest

@rjsadow
Copy link
Contributor

rjsadow commented Jun 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@iftachk
jobs: migrate kubernetes/image-builder jobs to eks cluster
e7e1dcc 
Add missing resource blocks

Signed-off-by: Iftach Konshtok <[email protected]>
@iftachk iftachk force-pushed the migrate-image-builder-jobs branch from cb61194 to e7e1dcc Compare June 20, 2023 15:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Jun 20, 2023

/lgtm
/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam June 20, 2023 15:41
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@ameukam
Copy link
Member

ameukam commented Jun 20, 2023

/assign @mboersma @AverageMarcus

@AverageMarcus
Copy link
Member

/lgtm

@mboersma
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iftachk, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit c538213 into kubernetes:master Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

@iftachk: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key image-builder-ova-presubmits.yaml using file config/jobs/kubernetes-sigs/image-builder/image-builder-ova-presubmits.yaml
  • key image-builder-presubmits.yaml using file config/jobs/kubernetes-sigs/image-builder/image-builder-presubmits.yaml

In response to this:

jobs: migrate kubernetes/image-builder jobs to eks cluster

  • Add missing resource blocks

/priority important-longterm
/area jobs

Part of #29722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AverageMarcus AverageMarcus mentioned this pull request Jun 21, 2023
Merged
@mboersma mboersma mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjsadow rjsadow rjsadow left review comments

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@mboersma mboersma

@AverageMarcus AverageMarcus

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iftachk @k8s-ci-robot @rjsadow @ameukam @AverageMarcus @mboersma