-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize: migrate presubmits to community clusters #29733
kustomize: migrate presubmits to community clusters #29733
Conversation
How can I get the test |
@ShivamTyagi12345 I don't know anything about the migration or prow infrastructure, maybe you can reach out to someone there to figure out how to get the test to pass? |
xslack: https://kubernetes.slack.com/archives/C09QZ4DQB/p1686255333214949 The test is failing because I would recommend setting some default values (you can ref #29629). Then reach out to the Kustomize OWNERS to see if they have any recommendations. If they're not sure then you can merge with the default values and iterate to fine tune the requests and limits if the jobs start failing. |
/retest |
cpu: 4000m | ||
limits: | ||
memory: "2000Mi" | ||
cpu: 500m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be 4000m to match the request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am doing this change. Let's look into the results
@rjsadow I see these values lead to the similar error |
/retest |
cpu: 4000m | ||
limits: | ||
memory: "2000Mi" | ||
cpu: 4000m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is erroring on the trailing white space after the 4000m.
cpu: 4000m
config/jobs/kubernetes-sigs/kustomize/kustomize-presubmit-master.yaml
23:23 error trailing spaces (trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I have remove d the trailing space, How are you seeing that this was the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is still some trailing whitespace after the CPU. You can look at the log that the k8s-ci-robot provides or from the job itself. Here's the link to the job logs https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/29733/pull-test-infra-verify-lint/1669558900354977792. In there if you just search for "error" you'll find the offending line(s).
/retitle kustomize: migrate presubmits to community clusters |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, ShivamTyagi12345 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ShivamTyagi12345: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR transitions the
kustomize-presubmit-master
job from the default cluster toeks-prow-build-cluster
👍ref: #29722