Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate kwok jobs to community clusters #29731

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

kranurag7
Copy link
Contributor

migrate kubernetes-sigs/kwok jobs to community clusters

Ref: #29722

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kranurag7!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kranurag7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 8, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and wojtek-t June 8, 2023 13:56
@rjsadow
Copy link
Contributor

rjsadow commented Jun 11, 2023

Thanks for submitting this @kranurag7! There is one modification that'll be needed for each of the jobs before we're ok to test. The Google-owned clusters did not require any resource definitions whereas the community-owned clusters do. For each of the containers in this job, can you please work with the kwok owners (@Huang-Wei and @wzshiming) to determine what good memory/cpu quotas would be?

@ameukam
Copy link
Member

ameukam commented Jun 13, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2023
@@ -55,6 +58,7 @@ presubmits:
- name: pull-kwok-e2e-test-main
decorate: true
path_alias: sigs.k8s.io/kwok
cluster: eks-prow-build-cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

          requests:
            memory: "1Gi"
            cpu: "1"
          limits:
            memory: "2Gi"
            cpu: "2"

I'm not sure of the exact request but I think it should be enough, if not I'll add more 😄.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other point of note, the pull-test-infra-unit requires guaranteed QoS so the requests will need to match the limits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks

          requests:
            memory: "2Gi"
            cpu: "2"
          limits:
            memory: "2Gi"
            cpu: "2"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjsadow After specifying the resources field, the tests are not able to detect the changes.

@rjsadow
Copy link
Contributor

rjsadow commented Jul 17, 2023

@kranurag7 are you still working on this PR?

@kranurag7
Copy link
Contributor Author

@rjsadow Thanks for the ping, I'll update the PR today.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2023
@wzshiming
Copy link
Member

/retest pull-test-infra-unit-test-race-detector-nonblocking

@k8s-ci-robot
Copy link
Contributor

@wzshiming: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-test-infra-gubernator
  • /test pull-test-infra-integration
  • /test pull-test-infra-prow-checkconfig
  • /test pull-test-infra-prow-image-build-test
  • /test pull-test-infra-unit-test
  • /test pull-test-infra-verify-cri-o
  • /test pull-test-infra-verify-lint

The following commands are available to trigger optional jobs:

  • /test pull-test-infra-bazel
  • /test pull-test-infra-prow-checkconfig-loose
  • /test pull-test-infra-unit-test-race-detector-nonblocking

Use /test all to run the following jobs that were automatically triggered:

  • pull-test-infra-gubernator
  • pull-test-infra-prow-checkconfig
  • pull-test-infra-prow-checkconfig-loose
  • pull-test-infra-unit-test
  • pull-test-infra-unit-test-race-detector-nonblocking
  • pull-test-infra-verify-lint

In response to this:

/retest pull-test-infra-unit-test-race-detector-nonblocking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wzshiming
Copy link
Member

/test pull-test-infra-unit-test-race-detector-nonblocking

@wzshiming
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kranurag7, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79144b1 into kubernetes:master Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

@kranurag7: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kwok-presubmits-main.yaml using file config/jobs/kubernetes-sigs/kwok/kwok-presubmits-main.yaml

In response to this:

migrate kubernetes-sigs/kwok jobs to community clusters

Ref: #29722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants