Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the default working dir for pod-utils #29712

Merged
merged 1 commit into from
Jun 7, 2023
Merged

update the default working dir for pod-utils #29712

merged 1 commit into from
Jun 7, 2023

Conversation

chendave
Copy link
Member

@chendave chendave commented Jun 7, 2023

This change intends to fix the path of metadata.

ref: #29693

/cc @chaodaiG
/cc @ike-ma
/cc @pacoxu

@k8s-ci-robot k8s-ci-robot requested review from chaodaiG and pacoxu June 7, 2023 02:53
@k8s-ci-robot
Copy link
Contributor

@chendave: GitHub didn't allow me to request PR reviews from the following users: ike-ma.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This change intends to fix the path of metadata.

ref: #29693

/cc @chaodaiG
/cc @ike-ma
/cc @pacoxu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 7, 2023
chendave
chendave commented Jun 7, 2023
View reviewed changes
config/jobs/kubernetes/sig-node/node-kubelet.yaml Outdated
- org: kubernetes
repo: kubernetes
base_ref: master
path_alias: k8s.io/kubernetes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case there is anything with the ordering, might not necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this indeed is not necessary, please revert this ordering

@chendave
Copy link
Member Author

chendave commented Jun 7, 2023

@chaodaiG would you pls approve this? let's see is that fix the problem, thanks!

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, chendave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit b936f25 into kubernetes:master Jun 7, 2023
@chendave chendave mentioned this pull request Jun 14, 2023
Closed
@chendave chendave deleted the try_fix branch June 14, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaodaiG chaodaiG chaodaiG approved these changes

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@chaodaiG chaodaiG

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chendave @k8s-ci-robot @chaodaiG