Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the job of ci-kubernetes-node-arm64-ubuntu-serial #29662

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

chendave
Copy link
Member

@chendave chendave commented Jun 1, 2023

  • remove the extra_ref to the kubernetes, but use the path_alias: k8s.io/kubernetes instead. periodic job doesn't support the top level path_alias.
  • add the extra_ref to the k8s.io/test-infra so that the image config file could be found.
  • added timeout config based on the initial pr

link to the log: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1664144092101087232

/cc @dims
/cc @pacoxu
/cc @ike-ma

@k8s-ci-robot k8s-ci-robot requested review from dims and pacoxu June 1, 2023 06:50
@k8s-ci-robot
Copy link
Contributor

@chendave: GitHub didn't allow me to request PR reviews from the following users: ike-ma.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

  • remove the extra_ref to the kubernetes, but use the path_alias: k8s.io/kubernetes instead.
  • add the extra_ref to the k8s.io/test-infra so that the image config file could be found.
  • added timeout config based on the initial pr

/cc @dims
/cc @pacoxu
/cc @ike-ma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 1, 2023
@chendave
Copy link
Member Author

chendave commented Jun 1, 2023

sorry guys, I hope this is last one to make it work, I just cannot find a way to test it locally on my desktop.

thanks for your time for the review!

@chendave
Copy link
Member Author

chendave commented Jun 1, 2023

I compared the config with the config defined in this file line by line to make sure I wasn't missed anything again: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 2, 2023
@pacoxu
Copy link
Member

pacoxu commented Jun 2, 2023

/lgtm

So the label should fix the missing configuration below?

Will use ginkgo flags as: -timeout=24h -focus="[Serial]" -skip="[Flaky]|[Slow]|[Benchmark]|[NodeSpecialFeature:.+]|[NodeSpecialFeature]|[NodeAlphaFeature:.+]|[NodeAlphaFeature]|[NodeFeature:Eviction]|[NodeFeature:NodeProblemDetector]|[NodeFeature:OOMScoreAdj]|[NodeFeature:DevicePluginProbe]|[NodeConformance]" -untilItFails=false --no-color -vF0602 01:42:59.241191 9342 gce_runner.go:112] While preparing GCE images: Could not read image config file provided: open /home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/arm/image-config-serial.yaml: no such file or directory

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2023
@chendave
Copy link
Member Author

chendave commented Jun 2, 2023

So the label should fix the missing configuration below?

I think so, because the file is from the test-infra, so we need to import the project.

@pacoxu
Copy link
Member

pacoxu commented Jun 2, 2023

/assign @endocrimes @SergeyKanzhelev

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, endocrimes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit ee10480 into kubernetes:master Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

@chendave: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

  • remove the extra_ref to the kubernetes, but use the path_alias: k8s.io/kubernetes instead. periodic job doesn't support the top level path_alias.
  • add the extra_ref to the k8s.io/test-infra so that the image config file could be found.
  • added timeout config based on the initial pr

link to the log: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1664144092101087232

/cc @dims
/cc @pacoxu
/cc @ike-ma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants