-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the ARM64 node_e2e test #29617
Fix the ARM64 node_e2e test #29617
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -127,29 +127,33 @@ periodics: | |
testgrid-dashboards: sig-node-kubelet | ||
testgrid-tab-name: kubelet-gce-e2e-arm64-ubuntu-serial | ||
description: "Run serial node e2e tests on ARM64 environment on Ubuntu" | ||
decorate: true | ||
extra_refs: | ||
- org: kubernetes | ||
repo: kubernetes | ||
base_ref: master | ||
path_alias: k8s.io/kubernetes | ||
labels: | ||
preset-service-account: "true" | ||
preset-k8s-ssh: "true" | ||
preset-dind-enabled: "true" | ||
spec: | ||
containers: | ||
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20230513-7e1db2f1bb-master | ||
command: | ||
- runner.sh | ||
args: | ||
- --repo=k8s.io/kubernetes=master | ||
- --timeout=240 | ||
- --root=/go/src | ||
- --scenario=kubernetes_e2e | ||
- kubetest2 | ||
- noop | ||
- --test=node | ||
- -- | ||
- --deployment=node | ||
- --repo-root=. | ||
- --gcp-zone=us-central1-a | ||
- --use-dockerized-build=true | ||
- --target-build-arch=linux/arm64 | ||
- --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/arm/image-config-serial.yaml | ||
- '--node-test-args=--container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/usr/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd*\"]}"' | ||
- --node-tests=true | ||
- --provider=gce | ||
- --test_args=--nodes=1 --focus="\[Serial\]" --skip="\[Flaky\]|\[Slow\]|\[Benchmark\]|\[NodeSpecialFeature:.+\]|\[NodeSpecialFeature\]|\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]|\[NodeFeature:Eviction\]|\[NodeFeature:NodeProblemDetector\]|\[NodeFeature:OOMScoreAdj\]|\[NodeFeature:DevicePluginProbe\]|\[NodeConformance\]" | ||
- --timeout=180m | ||
- --parallelism=1 | ||
- --focus-regex=\[Serial\] | ||
- --skip-regex=\[Flaky\]|\[Slow\]|\[Benchmark\]|\[NodeSpecialFeature:.+\]|\[NodeSpecialFeature\]|\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]|\[NodeFeature:Eviction\]|\[NodeFeature:NodeProblemDetector\]|\[NodeFeature:OOMScoreAdj\]|\[NodeFeature:DevicePluginProbe\]|\[NodeConformance\] | ||
- --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/arm/image-config-serial.yaml | ||
- '--test-args=--use-dockerized-build=true --target-build-arch=linux/arm64 --container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/usr/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd*\"]}"' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not quite familiar with this, but doesn't it duplicated with the below line for Why not add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! |
||
securityContext: | ||
privileged: true | ||
env: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this parameter was removed, as it's not available for kubetest2, and there is a timeout config from ginkgo,
ginkgo.timeout
which control how long the testsuit should run, and is 1hour by default. Let's see if that is enough.