Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chrisdoherty4 to CAPC owners #29597

Merged
merged 2 commits into from
May 26, 2023
Merged

Add chrisdoherty4 to CAPC owners #29597

merged 2 commits into from
May 26, 2023

Conversation

chrisdoherty4
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @chrisdoherty4. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims May 25, 2023 18:59
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels May 25, 2023
@chrisdoherty4
Copy link
Member Author

/cc @rohityadavcloud @dims

@chrisdoherty4 chrisdoherty4 mentioned this pull request May 25, 2023
Merged
@rohityadavcloud
Copy link
Member

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4, rohityadavcloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@rohityadavcloud
Copy link
Member

/verify-owners

@rohityadavcloud
Copy link
Member

@chrisdoherty4 I think you're member of the k8s-sigs org but not the k8s org, you need to fix that for example - https://github.com/kubernetes/org/blob/main/config/kubernetes/org.yaml

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 26, 2023
@chrisdoherty4
Copy link
Member Author

@chrisdoherty4 I think you're member of the k8s-sigs org but not the k8s org, you need to fix that for example - kubernetes/org@main/config/kubernetes/org.yaml

I raised a PR yesterday and its now merged (kubernetes/org#4248). I'll try verifying myself but you may need to redo the verify command.

/verify-owners

@chrisdoherty4
Copy link
Member Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 26, 2023
@weizhouapache
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@chrisdoherty4
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit bc91fd9 into kubernetes:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

Assignees

@rohityadavcloud rohityadavcloud

@weizhouapache weizhouapache

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisdoherty4 @k8s-ci-robot @rohityadavcloud @weizhouapache