Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud-provider-azure] Add IPv6 VMSS job and modified existing one #29516

Merged
merged 1 commit into from
May 17, 2023
Merged

[cloud-provider-azure] Add IPv6 VMSS job and modified existing one #29516

merged 1 commit into from
May 17, 2023

Conversation

lzhecheng
Copy link
Contributor

With CAPZ release-1.9, new templates are adopted.

@lzhecheng
[cloud-provider-azure] Add IPv6 VMSS job and modified existing one
5890bd0 
With CAPZ release-1.9, new templates are adopted.

Signed-off-by: Zhecheng Li <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 15, 2023
@lzhecheng
Copy link
Contributor Author

/hold
waiting for kubernetes-sigs/cloud-provider-azure#3879

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@lzhecheng lzhecheng mentioned this pull request May 16, 2023
Closed
@lzhecheng
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2023
@MartinForReal
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6faffae into kubernetes:master May 17, 2023
@k8s-ci-robot
Copy link
Contributor

@lzhecheng: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml

In response to this:

With CAPZ release-1.9, new templates are adopted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng deleted the cpa-ipv6-vmss branch May 17, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzhecheng @k8s-ci-robot @MartinForReal