Cluster API: Bump CAPI jobs for k8s 1.27 #29295
Conversation
k8s-ci-robot
added
cncf-cla: yes
furkatgofurov7
force-pushed
the
bump-capi-jobs-for-1-27
branch
from
1191a7f to
d56e056
Compare
furkatgofurov7
force-pushed
the
bump-capi-jobs-for-1-27
branch
from
d56e056 to
79f5021
Compare
config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
Outdated
Show resolved
Hide resolved
|
lgtm pending squash |
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-4.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-2.yaml
Outdated
Show resolved
Hide resolved
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-3.yaml
Outdated
Show resolved
Hide resolved
| @@ -1,56 +1,5 @@ | |||
| periodics: | |||
|
|
|||
There was a problem hiding this comment.
I think the following is missing:
For the main branch:
- periodics & presubmits:
- Bump KUBEBUILDER_ENVTEST_KUBERNETES_VERSION of the test-mink8s jobs to the new minimum supported management cluster version.
- periodics:
- Bump KUBERNETES_VERSION_MANAGEMENT of the e2e-mink8s job to the new minimum supported management cluster version.
Explanation:
With this PR we are supporting a new Kubernetes version v1.27. This moves our entire support range on the main branch up by one.
- mgmt cluster: v1.24-v1.27
- workload cluster: v1.22-v1.27
So KUBEBUILDER_ENVTEST_KUBERNETES_VERSION should be set to: v1.24.2
./hack/tools/bin/setup-envtest list | grep v1.24
(available) v1.24.2 linux/amd64
(available) v1.24.1 linux/amd64
(we probably should improve the comment above the KUBEBUILDER_ENVTEST_KUBERNETES_VERSION env var here)
KUBERNETES_VERSION_MANAGEMENT should be set to "stable-1.24"
There was a problem hiding this comment.
@sbueringer thanks a lot for detailed explanation and review, I should have addressed all your comments in the last commit(ff2c96a). PTAL.
lgtm pending squash
I will squash all commits once reviewers are happy with the state of the patch.
There was a problem hiding this comment.
Looks perfect, thank you!
I will squash all commits once reviewers are happy with the state of the patch.
Sounds reasonable :)
|
@furkatgofurov7 lgtm + approve from my side I think we can squash now. I thought about it again and I think we can merge this PR independent of kubernetes-sigs/cluster-api#8518 Basically this PR just introduces the 1.27=>1.28 test and does a few other smaller changes. But it doesn't change in any way which version e2e-full is testing or what clusterctl upgrade tests are doing (the latter was different in previous releases). So for me it's fine to merge this after squash |
Signed-off by: Furkat Gofurov ([email protected])
furkatgofurov7
force-pushed
the
bump-capi-jobs-for-1-27
branch
from
ff2c96a to
5dac492
Compare
@sbueringer done.
Yea, I was confused a bit at first why the 2 should be synced up, since this does not have any relation to clusterctl upgrade tests to my best knowledge. |
|
lgtm pending squash, great job! |
@fabriziopandini thanks, it is already squashed. |
|
Thank you! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@furkatgofurov7: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off by: Furkat Gofurov ([email protected])
Part of: kubernetes-sigs/cluster-api#8459