Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GNU C compiler for arm64 architecture #29197

Closed
wants to merge 1 commit into from
Closed

Add GNU C compiler for arm64 architecture #29197

wants to merge 1 commit into from

Conversation

ike-ma
Copy link
Contributor

@ike-ma ike-ma commented Mar 30, 2023

Enable cross compilation for building arm64 binaries in amd64 env

xRef:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ike-ma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 31, 2023
@ike-ma
Copy link
Contributor Author

ike-ma commented Mar 31, 2023

/cc @bobbypage
/cc @dims

@k8s-ci-robot k8s-ci-robot requested review from bobbypage and dims March 31, 2023 00:00
@ike-ma ike-ma mentioned this pull request Mar 31, 2023
Merged
@dims
Copy link
Member

dims commented Mar 31, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2023
@ike-ma
Copy link
Contributor Author

ike-ma commented Apr 4, 2023

/assign @bobbypage

mmiranda96
mmiranda96 approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@mmiranda96 mmiranda96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

images/kubekins-e2e/Dockerfile
@@ -37,9 +37,11 @@ RUN mkdir -p /go/src/k8s.io/kubernetes \
# - graphviz package for graphing profiles
# - bc for shell to junit
# - rpm for building RPMs with Bazel
# - gcc-aarch64-linux-gnu for cross-compile arm64 binaries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's keep the same order in comment and dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Updated based on suggestion.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ike-ma, mmiranda96
Once this PR has been reviewed and has the lgtm label, please assign justaugustus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ike-ma
Add GNU C compiler for arm64 architecture
d414c7c 
Enable cross compilation for building arm64 binaries in amd64 env
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@mmiranda96
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@ike-ma
Copy link
Contributor Author

ike-ma commented May 16, 2023 •
edited
Loading

/assign @justaugustus

@ike-ma
Copy link
Contributor Author

ike-ma commented May 16, 2023

/assign @BenTheElder

BenTheElder
BenTheElder reviewed May 16, 2023
View reviewed changes
images/kubekins-e2e/Dockerfile
# - rpm for building RPMs with Bazel
RUN apt-get update && \
apt-get install -y bc \
gcc-aarch64-linux-gnu \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be doing this. We're not installing an amd64 compiler here either.

@BenTheElder
Copy link
Member

We already have a solution for cross compiling in CI, let's not duplicate that?

Check the cross jobs from sig release.

I believe I commented with more detail on a related k/k PR

@ike-ma
Copy link
Contributor Author

ike-ma commented May 17, 2023

Close current PR, use dockerized build for ARM64 instead per kubernetes/kubernetes#117017 (comment)

@ike-ma ike-ma closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@mmiranda96 mmiranda96 mmiranda96 approved these changes

@puerco puerco Awaiting requested review from puerco

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@bobbypage bobbypage Awaiting requested review from bobbypage

@dims dims Awaiting requested review from dims

Assignees

@bobbypage bobbypage

@justaugustus justaugustus

@BenTheElder BenTheElder

@mmiranda96 mmiranda96

Labels
area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ike-ma @k8s-ci-robot @dims @mmiranda96 @BenTheElder @bobbypage @justaugustus