Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new job to test publishing bot #29118

Merged
merged 1 commit into from
Apr 5, 2023
Merged

add new job to test publishing bot #29118

merged 1 commit into from
Apr 5, 2023

Conversation

akhilerm
Copy link
Member

  • adds a new job to test publishing bot against k/k master branch

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2023
@k8s-ci-robot k8s-ci-robot requested review from nikhita and Verolop March 23, 2023 11:19
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 23, 2023
@akhilerm
Copy link
Member Author

/cc @nikhita @dims
/hold for kubernetes/publishing-bot#334

@k8s-ci-robot k8s-ci-robot requested a review from dims March 23, 2023 11:20
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2023
@akhilerm akhilerm force-pushed the add-publishing-bot-test branch from da3ceb6 to d706444 Compare March 23, 2023 11:21
@akhilerm akhilerm mentioned this pull request Mar 24, 2023
Closed
9 tasks
nikhita
nikhita reviewed Apr 4, 2023
View reviewed changes
config/jobs/kubernetes/publishing-bot/publishing-bot-presubmits.yaml
preset-dind-enabled: "true"
path_alias: k8s.io/publishing-bot
spec:
containers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set up cpu/memory requests and limits as per:

https://github.com/kubernetes/publishing-bot/blob/bd68f8104bf4615ae609226e8a9579127d035941/configs/kubernetes#L5-L8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nikhita
Copy link
Member

nikhita commented Apr 5, 2023

@akhilerm please also squash all the commits into a single commit. thanks!

@akhilerm akhilerm force-pushed the add-publishing-bot-test branch from 7ab440f to 4ca2986 Compare April 5, 2023 10:25
@akhilerm
add new job to test publishing bot
ba9eeb9 
- add new job to test publishing bot on every PR
- the test will be kept optional for now, since it is newly introduced and will take
some time to become stable

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm akhilerm force-pushed the add-publishing-bot-test branch from 4ca2986 to ba9eeb9 Compare April 5, 2023 10:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2023
nikhita
nikhita approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@nikhita
Copy link
Member

nikhita commented Apr 5, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023
@akhilerm
Copy link
Member Author

akhilerm commented Apr 5, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit e68b8bf into kubernetes:master Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

@akhilerm: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key publishing-bot-presubmits.yaml using file config/jobs/kubernetes/publishing-bot/publishing-bot-presubmits.yaml

In response to this:

  • adds a new job to test publishing bot against k/k master branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akhilerm akhilerm deleted the add-publishing-bot-test branch April 5, 2023 11:05
@nikhita nikhita mentioned this pull request May 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@nikhita nikhita nikhita approved these changes

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akhilerm @nikhita @k8s-ci-robot @dims