Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate maintenance-pull-janitor to pod-utils #29068

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Mar 16, 2023

Signed-off-by: jbpratt [email protected]

Ref. #17719 and #20760
/kind cleanup
/area jobs
/area bootstrap
/area prow/pod-utils
/sig testing
/cc @dims

update maintenance-pull-janitor to pod-utils following https://gist.github.com/dims/c1296f8ed42238baea0a5fcae45f4cf4

@k8s-ci-robot k8s-ci-robot requested a review from dims March 16, 2023 18:00
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/jobs area/bootstrap cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

@jbpratt: The label(s) area/prow/pod-utils cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: jbpratt [email protected]

Ref. #17719 and #20760
/kind cleanup
/area jobs
/area bootstrap
/area prow/pod-utils
/sig testing
/cc @dims

update maintenance-pull-janitor to pod-utils following https://gist.github.com/dims/c1296f8ed42238baea0a5fcae45f4cf4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jbpratt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbpratt
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spec:
containers:
- args:
- command:
- runner.sh
Copy link
Member

@BenTheElder BenTheElder Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this command doesn't do much on its own (wraps actual test command with things like setting up docker in docker if need be)
still need to run the "janitor" logic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- runner.sh
- runner.sh
- "scenarios/kubernetes_janitor.py"

that is what I was thinking, but I wasn't sure. Would it just be as simple as passing in the current scenario script? like https://gist.github.com/dims/c1296f8ed42238baea0a5fcae45f4cf4#file-after-yaml-L36-L38 or should the scenario script be moved?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the past we've used the scenario file as-is to start.
Sorry, my bandwidth will be very poor for the next few weeks with https://kubernetes.slack.com/archives/CCK68P2Q2/p1679420278418599 / https://kubernetes.io/blog/2023/03/10/image-registry-redirect/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated! No worries, I know you are busy :)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2023
@jbpratt jbpratt force-pushed the maintenance-pull-janitor-deprecated-bootstrap-migration branch from e5bb61c to 8668182 Compare March 22, 2023 08:42
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2023
@jbpratt jbpratt closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants