-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate maintenance-pull-janitor to pod-utils #29068
migrate maintenance-pull-janitor to pod-utils #29068
Conversation
@jbpratt: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @jbpratt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jbpratt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spec: | ||
containers: | ||
- args: | ||
- command: | ||
- runner.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this command doesn't do much on its own (wraps actual test command with things like setting up docker in docker if need be)
still need to run the "janitor" logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- runner.sh | |
- runner.sh | |
- "scenarios/kubernetes_janitor.py" |
that is what I was thinking, but I wasn't sure. Would it just be as simple as passing in the current scenario script? like https://gist.github.com/dims/c1296f8ed42238baea0a5fcae45f4cf4#file-after-yaml-L36-L38 or should the scenario script be moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the past we've used the scenario file as-is to start.
Sorry, my bandwidth will be very poor for the next few weeks with https://kubernetes.slack.com/archives/CCK68P2Q2/p1679420278418599 / https://kubernetes.io/blog/2023/03/10/image-registry-redirect/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated! No worries, I know you are busy :)
Signed-off-by: jbpratt <[email protected]>
e5bb61c
to
8668182
Compare
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Signed-off-by: jbpratt [email protected]
Ref. #17719 and #20760
/kind cleanup
/area jobs
/area bootstrap
/area prow/pod-utils
/sig testing
/cc @dims
update
maintenance-pull-janitor
to pod-utils following https://gist.github.com/dims/c1296f8ed42238baea0a5fcae45f4cf4