Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster API: adjust jobs to new support policy #28842

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 24, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2023
@sbueringer sbueringer changed the title Cluster API: adjust jobs to new support policy Cluster API: adjust jobs to new support policy, add Killian to approvers Feb 24, 2023
@sbueringer sbueringer force-pushed the pr-drop-jobs-according-to-policy branch from aed093a to 0cafddb Compare February 24, 2023 05:24
@sbueringer
Copy link
Member Author

/assign @vincepri @fabriziopandini

/cc @killianmuldoon

@@ -1,146 +1,5 @@
periodics:

- name: periodic-cluster-api-e2e-workload-upgrade-1-18-1-19-main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped 1.18 => 1.19 until 1.20 => 1.21

As main (upcoming v1.4) now only supports v1.21+ (xref: https://main.cluster-api.sigs.k8s.io/reference/versions.html)

@@ -48,7 +48,7 @@ periodics:
# To check the available envtest in Kubebuilder, please
# refer to https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases.
- name: KUBEBUILDER_ENVTEST_KUBERNETES_VERSION
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped mgmt cluster version of test-mink8s to v1.23 as new minimum mgmt cluster version is v1.23 now

@@ -121,14 +121,11 @@ periodics:
- "./scripts/ci-e2e.sh"
env:
- name: GINKGO_SKIP
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped mgmt cluster version of e2e-mink8s to v1.23 as new minimum mgmt cluster version is v1.23 now

This also means we don't have to skip ClusterClass tests anymore as ClusterClass is supported on v1.23

Copy link
Member

@furkatgofurov7 furkatgofurov7 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering about ClusterClass change, found the answer here )

@@ -375,50 +375,3 @@ periodics:
testgrid-tab-name: capi-e2e-release-1-3-1-25-1-26
testgrid-alert-email: [email protected]
testgrid-num-failures-to-alert: "4"

- name: periodic-cluster-api-e2e-workload-upgrade-1-26-latest-release-1-3
Copy link
Member Author

@sbueringer sbueringer Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kubernetes 1.27 release is ~ 3 weeks after the v1.4 Cluster API release.

Because of that support for Kubernetes 1.27 will likely be backported to v1.4 but definitely not to v1.3

This means we don't have to aim for compatibility between Cluster API v1.3 and Kubernetes 1.27. It's enough to test main (upcoming v1.4) against Kubernetes latest (upcoming 1.27)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for v1.2 below

@sbueringer sbueringer force-pushed the pr-drop-jobs-according-to-policy branch from cdc4513 to da90e1b Compare February 24, 2023 13:28
@sbueringer sbueringer changed the title Cluster API: adjust jobs to new support policy, add Killian to approvers Cluster API: adjust jobs to new support policy Feb 24, 2023
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see this happening!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 24d2612 into kubernetes:master Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-periodics-release-1-2-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-2-upgrades.yaml
  • key cluster-api-periodics-release-1-3-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-3-upgrades.yaml

In response to this:

Part of kubernetes-sigs/cluster-api#8040

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-drop-jobs-according-to-policy branch February 25, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants