-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster API: adjust jobs to new support policy #28842
Cluster API: adjust jobs to new support policy #28842
Conversation
aed093a
to
0cafddb
Compare
/assign @vincepri @fabriziopandini /cc @killianmuldoon |
@@ -1,146 +1,5 @@ | |||
periodics: | |||
|
|||
- name: periodic-cluster-api-e2e-workload-upgrade-1-18-1-19-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped 1.18 => 1.19 until 1.20 => 1.21
As main (upcoming v1.4) now only supports v1.21+ (xref: https://main.cluster-api.sigs.k8s.io/reference/versions.html)
@@ -48,7 +48,7 @@ periodics: | |||
# To check the available envtest in Kubebuilder, please | |||
# refer to https://github.com/kubernetes-sigs/kubebuilder/tree/tools-releases. | |||
- name: KUBEBUILDER_ENVTEST_KUBERNETES_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped mgmt cluster version of test-mink8s to v1.23 as new minimum mgmt cluster version is v1.23 now
@@ -121,14 +121,11 @@ periodics: | |||
- "./scripts/ci-e2e.sh" | |||
env: | |||
- name: GINKGO_SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped mgmt cluster version of e2e-mink8s to v1.23 as new minimum mgmt cluster version is v1.23 now
This also means we don't have to skip ClusterClass tests anymore as ClusterClass is supported on v1.23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering about ClusterClass change, found the answer here )
@@ -375,50 +375,3 @@ periodics: | |||
testgrid-tab-name: capi-e2e-release-1-3-1-25-1-26 | |||
testgrid-alert-email: [email protected] | |||
testgrid-num-failures-to-alert: "4" | |||
|
|||
- name: periodic-cluster-api-e2e-workload-upgrade-1-26-latest-release-1-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kubernetes 1.27 release is ~ 3 weeks after the v1.4 Cluster API release.
Because of that support for Kubernetes 1.27 will likely be backported to v1.4 but definitely not to v1.3
This means we don't have to aim for compatibility between Cluster API v1.3 and Kubernetes 1.27. It's enough to test main (upcoming v1.4) against Kubernetes latest (upcoming 1.27)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for v1.2 below
0cafddb
to
cdc4513
Compare
cdc4513
to
da90e1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great to see this happening!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of kubernetes-sigs/cluster-api#8040