Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add e2e test for etcd learner mode #28574

Merged
merged 1 commit into from
Feb 2, 2023
Merged

kubeadm: add e2e test for etcd learner mode #28574

merged 1 commit into from
Feb 2, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 28, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 28, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims January 28, 2023 08:53
@pacoxu pacoxu marked this pull request as draft January 28, 2023 08:53
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 28, 2023
@pacoxu pacoxu force-pushed the add-learner-mode-test branch from b7c13ad to d556242 Compare January 28, 2023 08:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 28, 2023
@pacoxu pacoxu marked this pull request as ready for review January 28, 2023 08:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t January 28, 2023 08:58
@pacoxu pacoxu force-pushed the add-learner-mode-test branch from d556242 to 73752b9 Compare January 28, 2023 09:02
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2023
This was referenced Jan 28, 2023
Merged
Merged
@pacoxu
Copy link
Member Author

pacoxu commented Jan 30, 2023

/assign @justinsb @fabriziopandini @vincepri
Do you have time to take a look?

@pacoxu pacoxu mentioned this pull request Jan 31, 2023
Closed
12 tasks
@pacoxu
Copy link
Member Author

pacoxu commented Jan 31, 2023

/cc @SataQiu

@k8s-ci-robot k8s-ci-robot requested a review from SataQiu January 31, 2023 08:52
fabriziopandini
fabriziopandini reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit c3c2b49 into kubernetes:master Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

@pacoxu: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-learner-mode.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-learner-mode.yaml

In response to this:

/assign @neolit123

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu pacoxu mentioned this pull request Feb 3, 2023
Closed
@pacoxu pacoxu mentioned this pull request Aug 29, 2023
Open
@pacoxu pacoxu mentioned this pull request Oct 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@justinsb justinsb

@neolit123 neolit123

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pacoxu @k8s-ci-robot @fabriziopandini @justinsb @neolit123 @vincepri