Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clusterctl versions to latest patches #25089

Merged
merged 1 commit into from
Feb 3, 2022
Merged

update clusterctl versions to latest patches #25089

merged 1 commit into from
Feb 3, 2022

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Feb 2, 2022

Update clusterctl version in all the upgrade e2e tests to the newest patch.
Ref: kubernetes-sigs/cluster-api#6056

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2022
@ykakarap
Copy link
Contributor Author

ykakarap commented Feb 2, 2022

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2022
@ykakarap
Copy link
Contributor Author

ykakarap commented Feb 2, 2022

/cc @sbueringer

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 2, 2022
@ykakarap ykakarap force-pushed the update-clusterctl-versions branch from 4c20f93 to 5eb38dd Compare February 2, 2022 15:39
@sbueringer
Copy link
Member

sbueringer commented Feb 2, 2022 •
edited
Loading

/lgtm
/assign @fabriziopandini

@fabriziopandini Up to you if you want to merge now or after the releases. It doesn't really matter, given that the jobs are already failing now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2022
@sbueringer
Copy link
Member

/test pull-test-infra-unit-test

@ykakarap
Copy link
Contributor Author

ykakarap commented Feb 3, 2022

/hold cancel

The required releases are now available.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, ykakarap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 83825dc into kubernetes:master Feb 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

@ykakarap: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-periodics-release-1-0.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-0.yaml
  • key cluster-api-periodics-release-1-1.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-1.yaml

In response to this:

Update clusterctl version in all the upgrade e2e tests to the newest patch.
Ref: kubernetes-sigs/cluster-api#6056

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@detiber detiber Awaiting requested review from detiber

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@ykakarap @sbueringer @fabriziopandini @k8s-ci-robot