Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document why /boskos directory exists, migrate to make rule #24872

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Document why /boskos directory exists, migrate to make rule #24872

merged 1 commit into from
Mar 7, 2022

Conversation

chaodaiG
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2022
BenTheElder
BenTheElder reviewed Jan 14, 2022
View reviewed changes
boskos/README.md

The only thing matters here is `./cmd/janitor/gcp_janitor.py` script, which is
still used by
[/scenarios/kubernetes_janitor.py#L66](https://github.com/kubernetes/test-infra/blob/d641897cea52d493ef883a4dfa6728ffdfa02dfa/scenarios/kubernetes_janitor.py#L66),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget, is boskos using a different copy of this when deployed to janitor GCP or is this also the main janitor script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boskos has it's own gcp_janitor.py script https://github.com/kubernetes-sigs/boskos/blob/master/cmd/janitor/gcp_janitor.py, which is much more recent this this one, assuming the other one is the default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know 🙈 , Jeff was probably the last person to know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case @ixdy still receives GitHub notification ^^

Copy link
Member

@ixdy ixdy Feb 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the Boskos janitor uses the script from kubernetes-sigs/boskos, since I think it uses the copy baked into the container, which would come from that repo.

I opened #17719 regarding the copy of gcp_janitor.py in test-infra. It was a potentially hairy cleanup effort, and it also wasn't clear whether the jobs even needed to run anymore. With the resolution of #20760, this can probably finally be deleted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tempted to just disable scheduling those and see what breaks :+)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2022
BenTheElder
BenTheElder approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Mar 4, 2022

/retest

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Mar 7, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7fa60e9 into kubernetes:master Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 7, 2022
@k8s-ci-robot
Copy link
Contributor

@chaodaiG: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

/cc @BenTheElder @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chaodaiG chaodaiG deleted the doc-boskos branch March 7, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/jobs area/prow/bazel-deprecation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@chaodaiG @k8s-ci-robot @BenTheElder @ixdy