-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cla: Switch over to EasyCLA #24844
cla: Switch over to EasyCLA #24844
Conversation
/cc @spiffxp |
@mrbobbytables are the links mentioned for support in the bot message the same for EasyCLA as well? test-infra/prow/plugins/cla/cla.go Lines 39 to 50 in cd3e975
|
/uncc @petr-muller @spiffxp |
I'm actually wondering if we want to have our own message at all - EasyCLA itself posts direct links to sign the CLA and support details. The one thing that our docs do have that theirs don't is updating affiliation and how to retrigger a check ( |
the provided message lgtm so /shrug but yeah the resigning cla stuff will need to be looked into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm not sure how much value we get by adding another comment, so maybe we disable that?
Yeah, I think we just remove it at this point |
ab0d6d3
to
6aeab72
Compare
I've created a new commit for removing the bot message: da7f147 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
👍
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM.
@MadhavJivrajani Once addressed, would you mind squashing? Thanks!
/lgtm cancel
This makes the required changes needed to support EasyCLA after it has been fully migrated: * Change the context checked from cla/linuxfoundation to EasyCLA * Update tests to reflect the changed context * Remove bot comment in case the CLA is not signed and default to the EasyCLA bot's message. * Change prow config to not treat EasyCLA as an optional context anymore. Add cla/linuxfoundation as the optional context and leave it there for an additional release cycle after EasyCLA is fully rolled out. Signed-off-by: Madhav Jivrajani <[email protected]>
da7f147
to
664921c
Compare
@cblecker made the changes and squashed, thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, dims, MadhavJivrajani, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@MadhavJivrajani: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This makes the required changes needed to support EasyCLA
after it has been fully migrated:
to the EasyCLA bot's message.
anymore. Add cla/linuxfoundation as the optional context and
leave it there for an additional release cycle after EasyCLA
is fully rolled out.
/area github-management
/sig contributor-experience
/assign @mrbobbytables @cblecker @nikhita
/hold