Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cla: Switch over to EasyCLA #24844

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Conversation

MadhavJivrajani
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani commented Jan 12, 2022

This makes the required changes needed to support EasyCLA
after it has been fully migrated:

  • Change the context checked from cla/linuxfoundation to EasyCLA
  • Update tests to reflect the changed context
  • Remove bot comment in case the CLA is not signed and default
    to the EasyCLA bot's message.
  • Change prow config to not treat EasyCLA as an optional context
    anymore. Add cla/linuxfoundation as the optional context and
    leave it there for an additional release cycle after EasyCLA
    is fully rolled out.

/area github-management
/sig contributor-experience
/assign @mrbobbytables @cblecker @nikhita
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2022
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Jan 12, 2022
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow area/prow/plugins Issues or PRs related to prow's plugins for the hook component labels Jan 12, 2022
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jan 12, 2022
@MadhavJivrajani
Copy link
Contributor Author

/cc @spiffxp

@MadhavJivrajani
Copy link
Contributor Author

MadhavJivrajani commented Jan 12, 2022

@mrbobbytables are the links mentioned for support in the bot message the same for EasyCLA as well?

:memo: **Please follow instructions at <https://git.k8s.io/community/CLA.md#the-contributor-license-agreement> to sign the CLA.**
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
---
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
- If you signed the CLA as a corporation, please sign in with your organization's credentials at <https://identity.linuxfoundation.org/projects/cncf> to be authorized.
- If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: <https://support.linuxfoundation.org/>
- Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]
<!-- need_sender_cla -->

@cblecker
Copy link
Member

/uncc @petr-muller @spiffxp
/assign

@mrbobbytables
Copy link
Member

I'm actually wondering if we want to have our own message at all - EasyCLA itself posts direct links to sign the CLA and support details. The one thing that our docs do have that theirs don't is updating affiliation and how to retrigger a check (/check-cla or for easycla /easycla) @cblecker @nikhita @alisondy what do you think?

Here is a screenshot of what it looks like:
Screen Shot 2022-01-12 at 9 00 43 AM

@alisondy
Copy link
Contributor

alisondy commented Jan 12, 2022

the provided message lgtm so /shrug

but yeah the resigning cla stuff will need to be looked into

Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not sure how much value we get by adding another comment, so maybe we disable that?

config/prow/config.yaml Show resolved Hide resolved
@mrbobbytables
Copy link
Member

Yeah I'm not sure how much value we get by adding another comment, so maybe we disable that?

Yeah, I think we just remove it at this point

@MadhavJivrajani
Copy link
Contributor Author

I've created a new commit for removing the bot message: da7f147
Will squash when things look good :)

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2022
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2022
@dims
Copy link
Member

dims commented Feb 3, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2022
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM.

@MadhavJivrajani Once addressed, would you mind squashing? Thanks!

/lgtm cancel

prow/plugins/cla/cla.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2022
This makes the required changes needed to support EasyCLA
after it has been fully migrated:

* Change the context checked from cla/linuxfoundation to EasyCLA
* Update tests to reflect the changed context
* Remove bot comment in case the CLA is not signed and default
  to the EasyCLA bot's message.
* Change prow config to not treat EasyCLA as an optional context
  anymore. Add cla/linuxfoundation as the optional context and
  leave it there for an additional release cycle after EasyCLA
  is fully rolled out.

Signed-off-by: Madhav Jivrajani <[email protected]>
@MadhavJivrajani
Copy link
Contributor Author

@cblecker made the changes and squashed, thanks!
PTAL :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, MadhavJivrajani, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrbobbytables
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit ad3598a into kubernetes:master Feb 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 5, 2022
@MadhavJivrajani MadhavJivrajani deleted the easy-cla branch February 5, 2022 12:29
@k8s-ci-robot
Copy link
Contributor

@MadhavJivrajani: Updated the config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

This makes the required changes needed to support EasyCLA
after it has been fully migrated:

  • Change the context checked from cla/linuxfoundation to EasyCLA
  • Update tests to reflect the changed context
  • Remove bot comment in case the CLA is not signed and default
    to the EasyCLA bot's message.
  • Change prow config to not treat EasyCLA as an optional context
    anymore. Add cla/linuxfoundation as the optional context and
    leave it there for an additional release cycle after EasyCLA
    is fully rolled out.

/area github-management
/sig contributor-experience
/assign @mrbobbytables @cblecker @nikhita
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/github-management Issues or PRs related to GitHub Management subproject area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants