gce-federation: Add KUBE_GCS_DEV_RELEASE_BUCKET #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @colhom |
| @@ -230,6 +230,7 @@ | |||
| export FEDERATION_PUSH_REPO_BASE="gcr.io/k8s-jkns-e2e-gce-federation" | |||
| export KUBE_GCE_ZONE="us-central1-f" #TODO(colhom): This should be generalized out to plural case | |||
| export KUBE_GCS_RELEASE_BUCKET=kubernetes-federation-release | |||
| export KUBE_GCS_DEV_RELEASE_BUCKET_MIRROR=kubernetes-federation-release | |||
There was a problem hiding this comment.
did you mean to add _MIRROR on this? in #28193 it was just KUBE_GCS_DEV_RELEASE_BUCKET.
In anticipation of re-adding kubernetes/kubernetes#28193 Fixes kubernetes#240 for good
zmerlynn
force-pushed
the
pull-from-dev-mirror
branch
from
7cdd098
to
da45c46
Compare
|
PTAL |
|
LGTM |
ixdy
added
the
lgtm
zmerlynn
added a commit
to zmerlynn/kubernetes
that referenced
this pull request
Jun 29, 2016
…l-ci-elsewhere"" Bring back kubernetes#28193. We caught a break in kubernetes/test-infra#240 and discovered the previous issue, fixed in kubernetes/test-infra#241 and kubernetes/test-infra#244, so I have a pretty good handle on what was causing the previous bringup issues (and it wasn't kubernetes#28193). By the time this merges, we'll have good signal on GKE in the `kubernetes-e2e-gke-updown` job. This reverts commit ee1d480.
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jun 29, 2016
Automatic merge from submit-queue Revert Revert of #28193 Bring back #28193. We caught a break in kubernetes/test-infra#240 and discovered the previous issue, fixed in kubernetes/test-infra#241 and kubernetes/test-infra#244, so I have a pretty good handle on what was causing the previous bringup issues (and it wasn't #28193). By the time this merges, we'll have good signal on GKE in several concurrent GKE jobs. This reverts commit ee1d480. []()
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jul 11, 2016
Automatic merge from submit-queue Migrate to kuberetes-release-dev []() This turns off the kubernetes-release-dev mirror. #28193 should have shifted all the references over, this should ensure that it's true. Along the way: Modify it so that the equal bucket and mirror is a noop for things like kubernetes/test-infra#244.
michelleN
pushed a commit
to michelleN/community
that referenced
this pull request
Nov 19, 2016
…here"" Bring back #28193. We caught a break in kubernetes/test-infra#240 and discovered the previous issue, fixed in kubernetes/test-infra#241 and kubernetes/test-infra#244, so I have a pretty good handle on what was causing the previous bringup issues (and it wasn't #28193). By the time this merges, we'll have good signal on GKE in the `kubernetes-e2e-gke-updown` job. This reverts commit ee1d48033366cfbb2e32fc98af6d37c0789e03c2.
michelleN
pushed a commit
to michelleN/community
that referenced
this pull request
Nov 21, 2016
…here"" Bring back #28193. We caught a break in kubernetes/test-infra#240 and discovered the previous issue, fixed in kubernetes/test-infra#241 and kubernetes/test-infra#244, so I have a pretty good handle on what was causing the previous bringup issues (and it wasn't #28193). By the time this merges, we'll have good signal on GKE in the `kubernetes-e2e-gke-updown` job. This reverts commit ee1d48033366cfbb2e32fc98af6d37c0789e03c2.
michelleN
pushed a commit
to michelleN/community
that referenced
this pull request
Nov 21, 2016
…here"" Bring back #28193. We caught a break in kubernetes/test-infra#240 and discovered the previous issue, fixed in kubernetes/test-infra#241 and kubernetes/test-infra#244, so I have a pretty good handle on what was causing the previous bringup issues (and it wasn't #28193). By the time this merges, we'll have good signal on GKE in the `kubernetes-e2e-gke-updown` job. This reverts commit ee1d48033366cfbb2e32fc98af6d37c0789e03c2.
michelleN
pushed a commit
to michelleN/community
that referenced
this pull request
Nov 30, 2016
…here"" Bring back #28193. We caught a break in kubernetes/test-infra#240 and discovered the previous issue, fixed in kubernetes/test-infra#241 and kubernetes/test-infra#244, so I have a pretty good handle on what was causing the previous bringup issues (and it wasn't #28193). By the time this merges, we'll have good signal on GKE in the `kubernetes-e2e-gke-updown` job. This reverts commit ee1d48033366cfbb2e32fc98af6d37c0789e03c2.
michelleN
pushed a commit
to michelleN/community
that referenced
this pull request
Nov 30, 2016
…here"" Bring back #28193. We caught a break in kubernetes/test-infra#240 and discovered the previous issue, fixed in kubernetes/test-infra#241 and kubernetes/test-infra#244, so I have a pretty good handle on what was causing the previous bringup issues (and it wasn't #28193). By the time this merges, we'll have good signal on GKE in the `kubernetes-e2e-gke-updown` job. This reverts commit ee1d48033366cfbb2e32fc98af6d37c0789e03c2.
munnerz
added a commit
to munnerz/test-infra
that referenced
this pull request
Aug 29, 2018
Enable DCO sign off checker for test-infra and cert-manager
mborsz
pushed a commit
to mborsz/test-infra
that referenced
this pull request
Dec 14, 2018
…ements_resource_usage2_kubemark ClusterLoader - Adding resource usage util for kubemark
MushuEE
pushed a commit
to MushuEE/test-infra
that referenced
this pull request
Mar 17, 2022
…objects. (kubernetes#244) * Update protoc-gen-openapi to represent map<string,string> as OpenAPI objects. * Simplify protoc-gen-openapi tests following guidance from @seaneganx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of re-adding kubernetes/kubernetes#28193
Fixes #240 for good