-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new CEL ValidationRules to alpha features we e2e test #24393
Conversation
@cheftako I got a request to add alpha e2e testing of the CEL alpha feature. I'm a bit unclear on why the only alpha feature test job is under sig-cloud-provider of it it's the right job to add tests to, but I couldn't find any else and it appears that this job runs some alpha feature tests that are not cloud provider specific, so maybe this is the right place. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/hold cancel |
@jpbetz: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This appears to be the primary test we use to test alpha features. It's accessible via
/test pull-kubernetes-e2e-gce-alpha-features
.Feature being tested: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2876-crd-validation-expression-language