Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refactor label for k/website PRs #23959

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Add refactor label for k/website PRs #23959

merged 3 commits into from
Oct 19, 2021

Conversation

reylejano
Copy link
Member

This label adds a new label for k/website PRs: refactor for PRs with large refactoring changes e.g. removes files or moves content

This was discussed on the SIG Docs meeting on Sept 21, 2021 and in issue kubernetes/website#29649

/sig docs
/area label_sync
/cc @sftim @parispittman @jimangel @divya-mohan0209

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 8, 2021
sftim
sftim reviewed Oct 9, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sftim
sftim reviewed Oct 9, 2021
View reviewed changes
label_sync/labels.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Oct 16, 2021

@reylejano I'd like to see this land - could you have another look at the PR?

@sftim
Copy link
Contributor

sftim commented Oct 16, 2021

BTW https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/23959/pull-test-infra-bazel/1447573969912729600 shows what you need to fix.

@reylejano
Copy link
Member Author

tests are passing now
@sftim @jimangel @divya-mohan0209 @parispittman , please take a look

sftim
sftim reviewed Oct 18, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2021
@sftim
Copy link
Contributor

sftim commented Oct 18, 2021

SIG Docs tech lead here. I'm happy with this.

@reylejano
Copy link
Member Author

/assign @spiffxp

spiffxp
spiffxp approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit b62fa2f into kubernetes:master Oct 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

@reylejano: Updated the label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

This label adds a new label for k/website PRs: refactor for PRs with large refactoring changes e.g. removes files or moves content

This was discussed on the SIG Docs meeting on Sept 21, 2021 and in issue kubernetes/website#29649

/sig docs
/area label_sync
/cc @sftim @parispittman @jimangel @divya-mohan0209

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@reylejano reylejano deleted the refactor-label branch October 19, 2021 01:30
@reylejano reylejano mentioned this pull request Oct 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@spiffxp spiffxp spiffxp approved these changes

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@jimangel jimangel Awaiting requested review from jimangel

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@spiffxp spiffxp

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@reylejano @sftim @k8s-ci-robot @spiffxp