-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/jobs: add pull-enhancements-test #23546
Conversation
decorate: true | ||
spec: | ||
containers: | ||
- image: golang:1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ends up running one of the same tests that verify does. Why not bump the verify job to the same golang image? To reduce blast radius.
Ideally the verify job would be make verify
but there are duplicate targets and not all of them pass. So since fixing that requires kubernetes/enhancement changes, hold off on bumping the verify image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh. I was just about to ask this :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related:
Let's prevent
make test
andmake tools
from breaking again by running them as a blocking presubmit