Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triage: prepare for alternate projects, datasets, buckets #23168

Merged
merged 3 commits into from
Aug 9, 2021
Merged

triage: prepare for alternate projects, datasets, buckets #23168

merged 3 commits into from
Aug 9, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 6, 2021 •
edited
Loading

Related:

Turns out k8s-gubernator was hardcoded in a bunch of places in the update_summaries script that kicks off the triage go binary

Add env vars with defaults that are still easily greppable, to allow the canary job to override:

  • the project billed for bq usage
  • the dataset:table to query for build info
  • the dataset:table to write temp test results
  • the gs://path/to/temp_test_results
  • the gs://path/to/triage

Then setup the canary job to override these. It will still fail because it can't write to k8s-gubernator's datasets, but I'd like to see it get that far first.

spiffxp added 3 commits August 6, 2021 14:48
@spiffxp
triage: dummy changes to trigger image build
01eaab8
@spiffxp
triage: prep for alt projects, datasets, buckets
ce6c028 
Turns out `k8s-gubernator` was hardcoded in a bunch of places in this
script

Add env vars with defaults that are still easily greppable

The canary job will need to override these
@spiffxp
config/jobs: override triage canary destinations
2832d3a
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/triage sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2021
@spiffxp spiffxp changed the title triage: prepare for alternate projects, datasets, buckets Turns out k8s-gubernator was hardcoded in a bunch of places in the update_summaries script that kicks off the triage go binary triage: prepare for alternate projects, datasets, buckets Aug 6, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 6, 2021

/cc @BenTheElder @MushuEE

@spiffxp spiffxp mentioned this pull request Aug 6, 2021
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Aug 9, 2021

/cc @ameukam @dims

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims August 9, 2021 15:49
@spiffxp
Copy link
Member Author

spiffxp commented Aug 9, 2021

/wg k8s-infra

ameukam
ameukam reviewed Aug 9, 2021
View reviewed changes
triage/interactive.js
@@ -303,7 +303,7 @@ function getData() {
setElementVisibility('btn-sig-group', false);
}

var url = '/k8s-gubernator/triage/';
var url = '/triage/';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not /k8s-triage/triage ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was for the benefit of running locally, but it didn't seem to make a difference either way. It could probably be url='' but I was mainly interested in getting the bucket name out of the source

@ameukam
Copy link
Member

ameukam commented Aug 9, 2021

Just one non-blocking question. Otherwise:
/lgtm
/hold
Remove hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit b6d134f into kubernetes:master Aug 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key wg-k8s-infra-test-infra.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-test-infra.yaml

In response to this:

Related:

Turns out k8s-gubernator was hardcoded in a bunch of places in the update_summaries script that kicks off the triage go binary

Add env vars with defaults that are still easily greppable, to allow the canary job to override:

  • the project billed for bq usage
  • the dataset:table to query for build info
  • the dataset:table to write temp test results
  • the gs://path/to/temp_test_results
  • the gs://path/to/triage

Then setup the canary job to override these. It will still fail because it can't write to k8s-gubernator's datasets, but I'd like to see it get that far first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the triage-env-overrides branch August 9, 2021 17:15
@spiffxp
Copy link
Member Author

spiffxp commented Aug 9, 2021

Postsubmits still failed off of the merge commit for this, e.g.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-triage/1424767317648084992

ERROR: (gcloud.builds.submit) INVALID_ARGUMENT: generic::invalid_argument: key "_PULL_BASE_REF" in the substitution data is not matched in the template

So I kept triggering cloudbuild with a locally-built version of image-builder until I got something that works: #23180

@spiffxp spiffxp mentioned this pull request Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@michaelkolber michaelkolber Awaiting requested review from michaelkolber

@thockin thockin Awaiting requested review from thockin

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@MushuEE MushuEE Awaiting requested review from MushuEE

@dims dims Awaiting requested review from dims

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/triage cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ameukam