Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: promote metrics-bigquery-canary #23115

Merged
merged 1 commit into from
Aug 3, 2021
Merged

config/jobs: promote metrics-bigquery-canary #23115

merged 1 commit into from
Aug 3, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 3, 2021

remove the old job which runs on google.com prow and runs using
bootstrap

rename the canary job to become the original job

the new job differs from the old job in that:

  • it runs on k8s-infra prow
  • it runs every 6h starting at 00:03 UTC instead of 24h interval
  • it also shows up on wg-k8s-infra-prow testgrid

/hold
this is dependent on having successfully moved the bucket to the
kubernetes.io GCP org

@spiffxp
config/jobs: promote metrics-bigquery-canary
dd08a69 
remove the old job which runs on google.com prow and runs using
bootstrap

rename the canary job to become the original job

the new job differs from the old job in that:
- it runs on k8s-infra prow
- it runs every 6h starting at 00:03 UTC instead of 24h interval
- it also shows up on wg-k8s-infra-prow testgrid
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2021
@k8s-ci-robot k8s-ci-robot requested review from chases2 and thockin August 3, 2021 17:20
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 3, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 3, 2021

/hold cancel
gs://k8s-metrics now lives over in kubernetes-public in the kubernetes.io GCP org, ref: kubernetes/k8s.io#1306 (comment)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2021
@matthyx
Copy link
Contributor

matthyx commented Aug 3, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit d19848b into kubernetes:master Aug 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 3, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-periodics.yaml using file config/jobs/kubernetes/test-infra/test-infra-periodics.yaml
  • key wg-k8s-infra-test-infra.yaml using file config/jobs/kubernetes/wg-k8s-infra/trusted/wg-k8s-infra-test-infra.yaml

In response to this:

remove the old job which runs on google.com prow and runs using
bootstrap

rename the canary job to become the original job

the new job differs from the old job in that:

  • it runs on k8s-infra prow
  • it runs every 6h starting at 00:03 UTC instead of 24h interval
  • it also shows up on wg-k8s-infra-prow testgrid

/hold
this is dependent on having successfully moved the bucket to the
kubernetes.io GCP org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 3, 2021
Merged
Closed
@spiffxp spiffxp deleted the mv-metrics-bigquery-job branch August 3, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@thockin thockin Awaiting requested review from thockin

Assignees

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @matthyx