-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images/bootstrap: build multi-archs amd64 & arm64 #23044
Conversation
Welcome @morlay! |
Hi @morlay. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bf714f0
to
41ddc29
Compare
312dac5
to
016e22c
Compare
3128133
to
4988e24
Compare
Isn't this deprecated in favor of decoration utils? |
/ok-to-test |
@howardjohn: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@morlay Can we also provide support for P/Z images along with arm? |
@deepsm007 what means |
ppc64le and s390x |
I think it couldn't |
In dockerfile file I see this is the place used to he source and installing it, this may even work as is on ppc64le platform too, |
if so, we could just add |
Lets wait and hear from @deepsm007 whether he can build image locally and things are fine. If yes - then we can modify this PR itself to include those options. |
I tried building the images locally, hitting the gcloud component error. |
@howardjohn: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: howardjohn, morlay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Looks like this image has been deprecated: https://github.com/kubernetes/test-infra/tree/master/images/bootstrap#readme, not sure whether the pursuing on this image is still acceptable. Might continue the work on krte image instead, pls see: #24783 |
changes here could make people use
docker buildx build
to build multi-arch imagesexample images: https://github.com/orgs/querycap/packages?repo_name=k8s-prow-images
rel: #16588