Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/bootstrap: build multi-archs amd64 & arm64 #23044

Closed
wants to merge 1 commit into from

Conversation

morlay
Copy link

@morlay morlay commented Jul 28, 2021

changes here could make people use docker buildx build to build multi-arch images

example images: https://github.com/orgs/querycap/packages?repo_name=k8s-prow-images

rel: #16588

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @morlay!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @morlay. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2021
@k8s-ci-robot k8s-ci-robot requested review from amwat and spiffxp July 28, 2021 01:48
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2021
@morlay morlay force-pushed the master branch 2 times, most recently from bf714f0 to 41ddc29 Compare July 28, 2021 02:51
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2021
@morlay morlay force-pushed the master branch 2 times, most recently from 312dac5 to 016e22c Compare July 28, 2021 03:16
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2021
@morlay morlay force-pushed the master branch 2 times, most recently from 3128133 to 4988e24 Compare July 28, 2021 04:09
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2021
@morlay morlay changed the title images/bootstrap: added arm64 support images/bootstrap: build multi-archs amd64 & arm64 Jul 28, 2021
@alvaroaleman
Copy link
Member

Isn't this deprecated in favor of decoration utils?

@chendave
Copy link
Member

chendave commented Aug 4, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 4, 2021
@k8s-ci-robot
Copy link
Contributor

@howardjohn: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepsm007
Copy link
Contributor

@morlay Can we also provide support for P/Z images along with arm?

@morlay
Copy link
Author

morlay commented Aug 23, 2021

@deepsm007 what means P/Z images ?

@deepsm007
Copy link
Contributor

@deepsm007 what means P/Z images ?

ppc64le and s390x

@morlay
Copy link
Author

morlay commented Aug 23, 2021

@deepsm007

I think it couldn't
cloud sdk not provide ppc64le and s390x binaries, https://cloud.google.com/sdk/docs/install
which seems not an opensource tool

@mkumatag
Copy link
Member

mkumatag commented Aug 24, 2021

@deepsm007

I think it couldn't
cloud sdk not provide ppc64le and s390x binaries, https://cloud.google.com/sdk/docs/install
which seems not an opensource tool

In dockerfile file I see this is the place used to he source and installing it, this may even work as is on ppc64le platform too,

https://github.com/ppc64le-cloud/test-infra/blob/f45196897c83015c049f417e5553e49bfd718b8e/images/all-in-one/Dockerfile#L128:L132

@morlay
Copy link
Author

morlay commented Aug 24, 2021

@mkumatag

if so, we could just add --platform to make build those images

@mkumatag
Copy link
Member

@mkumatag

if so, we could just add --platform to make build those images

Lets wait and hear from @deepsm007 whether he can build image locally and things are fine. If yes - then we can modify this PR itself to include those options.

@deepsm007
Copy link
Contributor

deepsm007 commented Aug 30, 2021

@mkumatag
if so, we could just add --platform to make build those images

Lets wait and hear from @deepsm007 whether he can build image locally and things are fine. If yes - then we can modify this PR itself to include those options.

I tried building the images locally, hitting the gcloud component error.

@k8s-ci-robot
Copy link
Contributor

@howardjohn: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn, morlay
To complete the pull request process, please assign amwat after the PR has been reviewed.
You can assign the PR to them by writing /assign @amwat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2022
@mkumatag
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2022
@chendave
Copy link
Member

Looks like this image has been deprecated: https://github.com/kubernetes/test-infra/tree/master/images/bootstrap#readme, not sure whether the pursuing on this image is still acceptable.

Might continue the work on krte image instead, pls see: #24783

@morlay morlay closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants