Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run CAPI/CAPV/CAPA/CAPZ jobs with kubekins-e2e 1.21 #22916

Merged
merged 1 commit into from
Jul 16, 2021
Merged

run CAPI/CAPV/CAPA/CAPZ jobs with kubekins-e2e 1.21 #22916

merged 1 commit into from
Jul 16, 2021

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 16, 2021 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

This PR moves CAPI/CAPV/CAPA/CAPZ jobs from the kubekins go-canary to the 1.21 image which ensures we're building with Go 1.16.x.
More details in kubernetes-sigs/cluster-api#4954 how the go-canary image with go 1.17 rc1 lead to problems

Fixes kubernetes-sigs/cluster-api#4954

CAPI:
/cc @CecileRobertMichon @vincepri @fabriziopandini
CAPV:
/cc @yastij @randomvariable
CAPA:
/cc @richardcase @randomvariable @sedefsavas
CAPZ:
/cc @CecileRobertMichon @nader-ziada

Feel free to cc other folks, I'm not entirely sure who to cc for each provider.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2021
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2021
@vincepri
Copy link
Member

LGTM

Would like a +1 from all providers as well before approving

@randomvariable
Copy link
Member

randomvariable commented Jul 16, 2021 •
edited
Loading

/approve

for CAPA & CAPV

@sbueringer sbueringer mentioned this pull request Jul 16, 2021
Closed
@randomvariable
Copy link
Member

I think @devigned might be about.

@sbueringer sbueringer mentioned this pull request Jul 16, 2021
Merged
devigned
devigned approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

vincepri
vincepri approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned, randomvariable, sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit a85f002 into kubernetes:master Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 16, 2021
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-aws-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-periodics.yaml
  • key cluster-api-provider-aws-postsubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-postsubmits.yaml
  • key cluster-api-provider-aws-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml
  • key cluster-api-provider-azure-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-periodics.yaml
  • key cluster-api-provider-azure-postsubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-postsubmits.yaml
  • key cluster-api-provider-azure-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits.yaml
  • key cluster-api-provider-vsphere-ci.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-ci.yaml
  • key cluster-api-provider-vsphere-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-presubmits.yaml
  • key cluster-api-periodics-main-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main-upgrades.yaml
  • key cluster-api-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-main.yaml
  • key cluster-api-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-main.yaml

In response to this:

Signed-off-by: Stefan Büringer [email protected]

This PR moves CAPI/CAPV/CAPA/CAPZ jobs from the kubekins go-canary to the 1.21 image which ensures we're building with Go 1.16.x.
More details in kubernetes-sigs/cluster-api#4954 how the go-canary image with go 1.17 rc1 lead to problems

Fixes kubernetes-sigs/cluster-api#4954

CAPI:
/cc @CecileRobertMichon @vincepri @fabriziopandini
CAPV:
/cc @yastij @randomvariable
CAPA:
/cc @richardcase @randomvariable @sedefsavas
CAPZ:
/cc @CecileRobertMichon @nader-ziada

Feel free to cc other folks, I'm not entirely sure who to cc for each provider.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-move-capi-jobs-to-kubekins-e2e-1.21 branch July 16, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@devigned devigned devigned approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

@randomvariable randomvariable Awaiting requested review from randomvariable

@richardcase richardcase Awaiting requested review from richardcase

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

@yastij yastij Awaiting requested review from yastij

Assignees

@devigned devigned

@randomvariable randomvariable

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

pull-cluster-api-verify is broken after the upgrade to go 1.17 rc1 CI image
5 participants
@sbueringer @randomvariable @vincepri @k8s-ci-robot @devigned