Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: config/jobs: Use gcb-docker-gcloud image for building alpine and git images #22609

Closed

Conversation

LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Jun 18, 2021

#22444 has broken the alpine postsubmit job.
In #22450 the git image is supposed to get the same treatment, so I'm changing the base for both jobs here already.

I'm not sure fixing it is as easy as this. PTAL.

Edit: Nope, this won't work

/cc @BenTheElder
/cc @fejta

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @LorbusChris. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2021
@LorbusChris
Copy link
Contributor Author

/hold
this doesn't work

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would expect this to get autobumped tomorrow (monday) but this will get things working now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@LorbusChris LorbusChris changed the title config/jobs: Use gcb-docker-gcloud image for building alpine and git images WIP: config/jobs: Use gcb-docker-gcloud image for building alpine and git images Jun 18, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2021
@LorbusChris
Copy link
Contributor Author

I don't think this here is the right approach.

Maybe the postsubmit job hit docker/buildx#584, which might be solved by simply re-trying?

@LorbusChris
Copy link
Contributor Author

Also, for completeness, here's the prow postsubmit failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-alpine/1405964567472771072

@fejta
Copy link
Contributor

fejta commented Jun 18, 2021

https://prow.k8s.io/?job=post-test-infra-push-alpine will have a rerun button (although maybe you can't click it so I did). Should be starting now

@fejta
Copy link
Contributor

fejta commented Jun 18, 2021

Rerun seems to have passed?

@LorbusChris
Copy link
Contributor Author

excellent, thank you!
/close

@k8s-ci-robot
Copy link
Contributor

@LorbusChris: Closed this PR.

In response to this:

excellent, thank you!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants