Setup new node image with swap enabled #22453

ike-ma · 2021-06-07T17:54:10Z

What type of PR is this?

/sig node
/priority important-soon

What this PR does / why we need it:

This PR
[x] Build images with swap for Ubuntu
[x] Add jobs to test-infra that use the images and enable the swap kubelet option for node e2e suite

Which issue(s) this PR fixes:

Context: kubernetes/enhancements#2400

Special notes for your reviewer:

The wiring PR and swap specific test is to be implemented in k/k as suggested by Elana (@ehashman), the feature gate is not yet wired
This PR has been manually tested with the following command (without feature gate for swap), and works as expected

kubetest
  --up \
  --down \
  --test \
  --provider=gce \
  --deployment=node \
  --gcp-project="${PROJECT}" \
  --gcp-zone="${ZONE}" \
  "--node-args=--image-config-file="${IMAGE_CONFIG_OUT} \
  '--node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"' \
  --node-tests=true \
  '--test_args=--nodes=1 --focus="\[NodeAlphaFeature:NodeMemorySwap\]" --skip="\[Flaky\]"' \
  '--timeout=300m'

k8s-ci-robot · 2021-06-07T17:54:12Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-06-07T17:54:17Z

Welcome @ike-ma!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-06-07T17:54:18Z

Hi @ike-ma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ehashman · 2021-06-07T18:02:00Z

/ok-to-test

ehashman · 2021-06-07T18:04:37Z

config/jobs/kubernetes/sig-node/node-kubelet.yaml

+- name: ci-kubernetes-node-kubelet-node-swap
+  interval: 4h


We don't need a periodic test until the code merges (since we won't be able to enable the feature flag yet), but I'm fine with enabling this with the kubelet flag + swap enabled for now. It should be a no-op.

Ack. I'll just remove this section for now then. Will add back when code is merged.

ehashman · 2021-06-07T18:06:19Z

config/jobs/kubernetes/sig-node/node-kubelet.yaml

+          - --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"
+          - --node-tests=true
+          - --provider=gce
+          - --test_args=--nodes=1 --focus="\[NodeAlphaFeature:NodeMemorySwap\]"


I've been avoiding using new NodeAlphaFeature tags where possible.

I think the focus of this test should be to run the full node e2e suite with swap on, per https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2400-node-swap/README.md#test-plan

Done. Updated to --focus="\[NodeConformance\]|\[NodeFeature:.+\]" --skip="\[Flaky\]|\[Slow\]|\[Serial\]" similar to cgroup tests

ehashman · 2021-06-07T18:08:32Z

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

+            - --gcp-project=k8s-jkns-pr-node-e2e
+            - --gcp-zone=us-west1-b
+            - --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/image-config-swap.yaml
+            - --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"


Suggested change

- --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"

- --node-test-args=--feature-gates=NodeSwapEnabled=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"

I'm not sure if we want the DynamicKubeletConfig flag on as we're deprecating it. We will definitely need NodeSwapEnabled for this to be able to test changes.

Updated as suggested

ehashman · 2021-06-07T18:09:00Z

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

+            - --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"
+            - --node-tests=true
+            - --provider=gce
+            - --test_args=--nodes=1 --focus="\[NodeAlphaFeature:NodeMemorySwap\]"


Same comment as above re: focus.

Done. Updated to --focus="\[NodeConformance\]|\[NodeFeature:.+\]" --skip="\[Flaky\]|\[Slow\]|\[Serial\]" similar to cgroup tests

ehashman · 2021-06-07T18:09:51Z

jobs/e2e_node/image-config-swap.yaml

+# `gcloud compute --project <to-project> disks create <image name> --image=https://www.googleapis.com/compute/v1/projects/<from-project>/global/images/<image-name>`
+# `gcloud compute --project <to-project> images create <image-name> --source-disk=<image-name>`
+images:
+  ubuntu: #With1GSwap


Per the spec, we want to test two distros. Ubuntu is a great start, can we also do something RHEL-based?

Done. Added fedora image with 1G swap and swap accounting enabled.

ike-ma

Addressed previous comments, and added fedora support

ike-ma · 2021-06-15T21:59:00Z

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

+            - --gcp-project=k8s-jkns-pr-node-e2e
+            - --gcp-zone=us-west1-b
+            - --node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/image-config-swap.yaml
+            - --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"


Updated as suggested

ike-ma · 2021-06-15T21:59:50Z

config/jobs/kubernetes/sig-node/node-kubelet.yaml

+          - --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"
+          - --node-tests=true
+          - --provider=gce
+          - --test_args=--nodes=1 --focus="\[NodeAlphaFeature:NodeMemorySwap\]"


Done. Updated to --focus="\[NodeConformance\]|\[NodeFeature:.+\]" --skip="\[Flaky\]|\[Slow\]|\[Serial\]" similar to cgroup tests

ike-ma · 2021-06-15T22:02:12Z

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

+            - --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"
+            - --node-tests=true
+            - --provider=gce
+            - --test_args=--nodes=1 --focus="\[NodeAlphaFeature:NodeMemorySwap\]"


Done. Updated to --focus="\[NodeConformance\]|\[NodeFeature:.+\]" --skip="\[Flaky\]|\[Slow\]|\[Serial\]" similar to cgroup tests

ike-ma · 2021-06-15T22:02:52Z

jobs/e2e_node/image-config-swap.yaml

+# `gcloud compute --project <to-project> disks create <image name> --image=https://www.googleapis.com/compute/v1/projects/<from-project>/global/images/<image-name>`
+# `gcloud compute --project <to-project> images create <image-name> --source-disk=<image-name>`
+images:
+  ubuntu: #With1GSwap


Done. Added fedora image with 1G swap and swap accounting enabled.

ike-ma · 2021-06-15T22:03:49Z

config/jobs/kubernetes/sig-node/node-kubelet.yaml

+- name: ci-kubernetes-node-kubelet-node-swap
+  interval: 4h


Ack. I'll just remove this section for now then. Will add back when code is merged.

ike-ma · 2021-06-15T22:26:36Z

Fedora tests:

Tested with kubetest (without FeatureGate for EnableNodeSwap)

ARTIFACTS="${TMPDIR}" JENKINS_GCE_SSH_PRIVATE_KEY_FILE="${SSH_KEY}" KUBE_SSH_USER=core \
/usr/local/google/home/ikema/go-k8s-oss/bin/kubetest \
  --up \
  --down \
  --test \
  --provider=gce \
  --deployment=node \
  --gcp-project="${PROJECT}" \
  --gcp-zone="${ZONE}" \
  '--node-test-args=--feature-gates=DynamicKubeletConfig=true,LocalStorageCapacityIsolation=true --container-runtime=remote --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--fail-swap-on=false --cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service --non-masquerade-cidr=0.0.0.0/0" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"' \
  "--node-args=--image-config-file="${IMAGE_CONFIG_OUT} \
  --node-tests=true \
  '--test_args=--nodes=1 --focus="\[NodeAlphaFeature:NodeMemorySwap\]" --skip="\[Flaky\]"' \
  '--timeout=300m' 2>&1 | tee -i "${TMPDIR}/build-log.txt"

Logged into the provisioned node and manually verified

[Pass] 1G swap added

[core@localhost ~]$ free -h
               total        used        free      shared  buff/cache   available
Mem:           7.3Gi       950Mi       335Mi       522Mi       6.0Gi       5.6Gi
Swap:          1.0Gi       0.0Ki       1.0Gi

[Pass] Let container consumer more memory than requested, container will fail as expected when no swap allowed

[core@localhost ~]$ sudo docker run --memory 50m --memory-swap 50m --rm progrium/stress --vm 1 --vm-bytes 100m --timeout 1s
stress: FAIL: [1] (416) <-- worker 7 got signal 9
stress: WARN: [1] (418) now reaping child worker processes
stress: FAIL: [1] (422) kill error: No such process
stress: FAIL: [1] (452) failed run completed in 1s
stress: info: [1] dispatching hogs: 0 cpu, 0 io, 1 vm, 0 hdd
stress: dbug: [1] using backoff sleep of 3000us
stress: dbug: [1] setting timeout to 1s
stress: dbug: [1] --> hogvm worker 1 [7] forked

[Pass] Let container consumer more memory than requested, container will succeed as expected when using unlimited swap (-1)

[core@localhost ~]$ sudo docker run --memory 50m --memory-swap -1 --rm progrium/stress --vm 1 --vm-bytes 100m --timeout 1s
stress: info: [1] dispatching hogs: 0 cpu, 0 io, 1 vm, 0 hdd
stress: dbug: [1] using backoff sleep of 3000us
stress: dbug: [1] setting timeout to 1s
stress: dbug: [1] --> hogvm worker 1 [7] forked
stress: dbug: [1] <-- worker 7 signalled normally
stress: info: [1] successful run completed in 1s

ehashman

I suggest that we add the manual tests you've written above to the e2e suite to be selected as part of Feature:NodeSwap work.

/skip
/lgtm

* Support Ubuntu and Fedora * Tested with docker command on node

k8s-ci-robot · 2021-06-16T22:16:02Z

@ike-ma: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-test-infra-gubernator	`9180f79`	link	`/test pull-test-infra-gubernator`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ehashman · 2021-06-17T21:49:36Z

/skip

sjenning · 2021-06-17T21:52:18Z

/approve

k8s-ci-robot · 2021-06-17T21:52:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ike-ma, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/jobs/kubernetes/sig-node/OWNERS~~ [sjenning]
~~jobs/e2e_node/OWNERS~~ [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2021-06-17T21:53:43Z

in general if you don't see an error that makes sense: expand the full log. from the end of the log:

Gubernator configuration file is out of sync!
39a40
>   - pull-kubernetes-node-swap-fedora
Run `gubernator/update_config.sh`

the log highlighting is iffy, and can point you towards spurious errors that are not the real problem.

ehashman

/lgtm

ehashman · 2021-06-17T23:11:58Z

/close

k8s-ci-robot · 2021-06-17T23:12:06Z

@ehashman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 7, 2021

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 7, 2021

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 7, 2021

k8s-ci-robot requested review from alejandrox1 and MHBauer June 7, 2021 17:54

k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2021

ike-ma force-pushed the swap-ci branch from 4e26139 to d0361f8 Compare June 7, 2021 17:58

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 7, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2021

ehashman reviewed Jun 7, 2021

View reviewed changes

ike-ma force-pushed the swap-ci branch from d0361f8 to 16d6e2e Compare June 15, 2021 22:18

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2021

ike-ma commented Jun 15, 2021

View reviewed changes

ike-ma force-pushed the swap-ci branch from 16d6e2e to 06accb9 Compare June 15, 2021 22:28

ehashman reviewed Jun 16, 2021

View reviewed changes

k8s-ci-robot assigned ehashman Jun 16, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021

Setup new node image with swap enabled

9180f79

* Support Ubuntu and Fedora * Tested with docker command on node

ike-ma force-pushed the swap-ci branch from 06accb9 to 9180f79 Compare June 16, 2021 22:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021

ehashman mentioned this pull request Jun 16, 2021

Alpha node swap support kubernetes/kubernetes#102823

Merged

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021

ehashman reviewed Jun 17, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2021

ehashman mentioned this pull request Jun 17, 2021

Setup new node image with swap enabled #22602

Merged

k8s-ci-robot closed this Jun 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup new node image with swap enabled #22453

Setup new node image with swap enabled #22453

ike-ma commented Jun 7, 2021

k8s-ci-robot commented Jun 7, 2021

k8s-ci-robot commented Jun 7, 2021

k8s-ci-robot commented Jun 7, 2021

ehashman commented Jun 7, 2021

ehashman Jun 7, 2021

ike-ma Jun 15, 2021

ehashman Jun 7, 2021

ike-ma Jun 15, 2021

ehashman Jun 7, 2021

ike-ma Jun 15, 2021

ehashman Jun 7, 2021

ike-ma Jun 15, 2021

ehashman Jun 7, 2021

ike-ma Jun 15, 2021

ike-ma left a comment

ike-ma Jun 15, 2021

ike-ma Jun 15, 2021

ike-ma Jun 15, 2021

ike-ma Jun 15, 2021

ike-ma Jun 15, 2021

ike-ma commented Jun 15, 2021

ehashman left a comment

k8s-ci-robot commented Jun 16, 2021

ehashman commented Jun 17, 2021

sjenning commented Jun 17, 2021

k8s-ci-robot commented Jun 17, 2021

BenTheElder commented Jun 17, 2021

ehashman left a comment

ehashman commented Jun 17, 2021

k8s-ci-robot commented Jun 17, 2021

	- --node-test-args=--feature-gates=DynamicKubeletConfig=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"
	- --node-test-args=--feature-gates=NodeSwapEnabled=true --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --fail-swap-on=false"

Setup new node image with swap enabled #22453

Setup new node image with swap enabled #22453

Conversation

ike-ma commented Jun 7, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

k8s-ci-robot commented Jun 7, 2021

k8s-ci-robot commented Jun 7, 2021

k8s-ci-robot commented Jun 7, 2021

ehashman commented Jun 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ike-ma left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ike-ma commented Jun 15, 2021

ehashman left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jun 16, 2021

ehashman commented Jun 17, 2021

sjenning commented Jun 17, 2021

k8s-ci-robot commented Jun 17, 2021

BenTheElder commented Jun 17, 2021

ehashman left a comment

Choose a reason for hiding this comment

ehashman commented Jun 17, 2021

k8s-ci-robot commented Jun 17, 2021