jobs: exit ci-k8sio-audit early #22239
Conversation
Two reasons to exit this job early. First, like any good bash script, exit when there's been an error or attempt to use an unset variable. This will prevent the job from opening a mass-deletion PR if the audit script fails. Instead, the job will fail, which will eventually fire an alert via prow's reporters or testgrid's alerter. Second, exit if there are no new changes in the audit/ directory to push. This should prevent the job from continually rebasing an open PR without modifying any files in audit/, which will make GitHub notifications for the PR more meaningful.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| git push -f "https://${GH_USER}:${GH_TOKEN}@github.com/${GH_USER}/${FORK_GH_REPO}" "HEAD:${FORK_GH_BRANCH}" 2>/dev/null | ||
|
|
||
| echo "Creating PR to merge ${GH_USER}:${FORK_GH_BRANCH} into k8s.io:main..." >&2 | ||
| echo "Creating or updating PR to merge ${GH_USER}:${FORK_GH_BRANCH} into kubernetes:main..." >&2 |
There was a problem hiding this comment.
Not blocking but you mean:
| echo "Creating or updating PR to merge ${GH_USER}:${FORK_GH_BRANCH} into kubernetes:main..." >&2 | |
| echo "Creating or updating PR to merge ${GH_USER}:${FORK_GH_BRANCH} into k8s.io:main..." >&2 |
?
I would have preferred something like github.com/kubernetes/k8s.io:main.
There was a problem hiding this comment.
The original message was inconsistent. This brings it into parity with what GitHub shows on PRs:
That said, I like your message better, will address in followup.
Though honestly I sorta feel like this should be pr-creator's job. The closest it gets is
time="2021-05-19T13:10:22Z" level=info msg="PR kubernetes/k8s.io#2011 will merge cncf-ci:autoaudit-prow into main: audit: update as of 2021-05-19"
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@spiffxp: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Two reasons to exit this job early.
First, like any good bash script, exit when there's been an error
or attempt to use an unset variable. This will prevent the job from
opening a mass-deletion PR if the audit script fails. Instead, the job
will fail, which will eventually fire an alert via prow's reporters or
testgrid's alerter.
Second, exit if there are no new changes in the audit/ directory to
push. This should prevent the job from continually rebasing an open PR
without modifying any files in audit/, which will make GitHub
notifications for the PR more meaningful.
This should address the second part of kubernetes/k8s.io#2055