Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated hyperkube image building jobs #21941

Merged
merged 2 commits into from
May 12, 2021
Merged

Remove deprecated hyperkube image building jobs #21941

merged 2 commits into from
May 12, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Apr 25, 2021 •
edited
Loading

  • Remove deprecated hyperkube image building jobs
  • Rename area/hyperkube label to deprecated/hyperkube

Tracking issue: kubernetes/release#2017

/hold until v1.18 and hyperkube is EOL (on 5/12/21)
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Apr 25, 2021
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and fejta April 25, 2021 03:58
@k8s-ci-robot k8s-ci-robot added area/jobs area/label_sync Issues or PRs related to code in /label_sync area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2021
This was referenced Apr 25, 2021
Closed
Merged
hasheddan
hasheddan approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2021
xmudrii
xmudrii approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fejta
fejta approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, hasheddan, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@justaugustus
Copy link
Member Author

It's been real, hyperkube!
/hold cancel
ref: https://groups.google.com/u/1/g/kubernetes-dev/c/c9mDzTsHnxM

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 37d80b4 into kubernetes:master May 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 12, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key k8s-staging-build-image.yaml using file config/jobs/image-pushing/releng/k8s-staging-build-image.yaml
    • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml
  • label-config configmap in namespace test-pods at cluster test-infra-trusted using the following files:
    • key labels.yaml using file label_sync/labels.yaml

In response to this:

  • Remove deprecated hyperkube image building jobs
  • Rename area/hyperkube label to deprecated/hyperkube

Tracking issue: kubernetes/release#2017

/hold until v1.18 and hyperkube is EOL (on 5/12/21)
cc: @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@xmudrii xmudrii xmudrii approved these changes

@fejta fejta fejta approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@saschagrunert saschagrunert

@fejta fejta

@xmudrii xmudrii

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @saschagrunert @fejta @xmudrii @hasheddan