Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last releng images builder prow jobs #21364

Merged
merged 7 commits into from
Mar 13, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 13, 2021

  • Add last image build jobs
  • turn all presubmits jobs required

k/release associate pr: kubernetes/release#1950

/assign @justaugustus @saschagrunert @hasheddan

tracking issue: kubernetes/release#1850

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2021
@k8s-ci-robot k8s-ci-robot requested review from tpepper and xmudrii March 13, 2021 14:42
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 13, 2021
@cpanato cpanato changed the title WIP Add last releng images builder prow jobs Add last releng images builder prow jobs Mar 13, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato -- Just a few nits

config/jobs/image-pushing/releng/k8s-staging-releng.yaml Outdated Show resolved Hide resolved
config/jobs/kubernetes/release/release-config.yaml Outdated Show resolved Hide resolved
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f9f245 into kubernetes:master Mar 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-releng.yaml using file config/jobs/image-pushing/releng/k8s-staging-releng.yaml
  • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml

In response to this:

  • Add last image build jobs
  • turn all presubmits jobs required

k/release associate pr: kubernetes/release#1950

/assign @justaugustus @saschagrunert @hasheddan

tracking issue: kubernetes/release#1850

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the k8s-ci-builder branch March 13, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants