-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: fix wrong image directory #21363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
after gets merged I will create a temporary PR to double-check the job |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hasheddan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cpanato: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
@cpanato -- Now that we know this pattern works, let's do two things in this PR:
- Create all jobs for the outstanding presubmits
- Making the presubmits blocking
(oooof, too slow I guess) |
@justaugustus will do in the next PR |
A wrong image directory was introduced in the job created by this PR #21344
it should use
images/k8s-cloud-builder
instead ofimages/releng/k8s-ci-builder
.The
images/releng/k8s-ci-builder
is the next job to be created./kind bug
/assign @justaugustus @saschagrunert @hasheddan