Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: fix wrong image directory #21363

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 13, 2021

A wrong image directory was introduced in the job created by this PR #21344

it should use images/k8s-cloud-builder instead of images/releng/k8s-ci-builder.

The images/releng/k8s-ci-builder is the next job to be created.
/kind bug
/assign @justaugustus @saschagrunert @hasheddan

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 13, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato
Copy link
Member Author

cpanato commented Mar 13, 2021

after gets merged I will create a temporary PR to double-check the job

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 24a0c92 into kubernetes:master Mar 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml

In response to this:

A wrong image directory was introduced in the job created by this PR #21344

it should use images/k8s-cloud-builder instead of images/releng/k8s-ci-builder.

The images/releng/k8s-ci-builder is the next job to be created.
/kind bug
/assign @justaugustus @saschagrunert @hasheddan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@cpanato -- Now that we know this pattern works, let's do two things in this PR:

  1. Create all jobs for the outstanding presubmits
  2. Making the presubmits blocking

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2021
@justaugustus
Copy link
Member

(oooof, too slow I guess)

@cpanato cpanato deleted the fix-job branch March 13, 2021 14:40
@cpanato
Copy link
Member Author

cpanato commented Mar 13, 2021

@justaugustus will do in the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants