-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: Update cross image presubmit to push to the correct staging project #21307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpanato -- Let's mimic the post-submit here:
test-infra/config/jobs/image-pushing/releng/k8s-staging-build-image.yaml
Lines 113 to 138 in ff6abef
- name: post-release-push-image-kube-cross | |
cluster: k8s-infra-prow-build-trusted | |
annotations: | |
testgrid-dashboards: sig-release-releng-informing, sig-release-master-informing, sig-release-image-pushes | |
testgrid-alert-email: [email protected] | |
decorate: true | |
run_if_changed: '^images\/build\/cross\/' | |
branches: | |
- ^master$ | |
spec: | |
serviceAccountName: gcb-builder | |
containers: | |
- image: gcr.io/k8s-testimages/image-builder:v20210302-aa40187 | |
command: | |
- /run.sh | |
args: | |
- --project=k8s-staging-build-image | |
- --scratch-bucket=gs://k8s-staging-build-image-gcb | |
- --build-dir=. | |
- images/build/cross | |
env: | |
- name: LOG_TO_STDOUT | |
value: "y" | |
rerun_auth_config: | |
github_team_ids: | |
- 2241179 # release-managers |
Namely: use the --project
flag to set the project, instead of env vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errr, nevermind. I see it's set further up in the config.
/retitle releng: Update cross image presubmit to push to the correct staging project
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the |
@cpanato: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yep, see my second review: #21307 (review) |
as discussed here: kubernetes/k8s.io#1772 we should try to push the image to the project that is running on.
Later I will check about the
--local
flag/assign @spiffxp @justaugustus