Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: Update cross image presubmit to push to the correct staging project #21307

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 11, 2021

as discussed here: kubernetes/k8s.io#1772 we should try to push the image to the project that is running on.
Later I will check about the --local flag

/assign @spiffxp @justaugustus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato -- Let's mimic the post-submit here:

- name: post-release-push-image-kube-cross
cluster: k8s-infra-prow-build-trusted
annotations:
testgrid-dashboards: sig-release-releng-informing, sig-release-master-informing, sig-release-image-pushes
testgrid-alert-email: [email protected]
decorate: true
run_if_changed: '^images\/build\/cross\/'
branches:
- ^master$
spec:
serviceAccountName: gcb-builder
containers:
- image: gcr.io/k8s-testimages/image-builder:v20210302-aa40187
command:
- /run.sh
args:
- --project=k8s-staging-build-image
- --scratch-bucket=gs://k8s-staging-build-image-gcb
- --build-dir=.
- images/build/cross
env:
- name: LOG_TO_STDOUT
value: "y"
rerun_auth_config:
github_team_ids:
- 2241179 # release-managers

Namely: use the --project flag to set the project, instead of env vars

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errr, nevermind. I see it's set further up in the config.

/retitle releng: Update cross image presubmit to push to the correct staging project
/lgtm

@k8s-ci-robot k8s-ci-robot changed the title releng: use registry for the staging project releng: Update cross image presubmit to push to the correct staging project Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Mar 11, 2021

the --project does not set the registry variable

@k8s-ci-robot k8s-ci-robot merged commit 65ff045 into kubernetes:master Mar 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-config.yaml using file config/jobs/kubernetes/release/release-config.yaml

In response to this:

as discussed here: kubernetes/k8s.io#1772 we should try to push the image to the project that is running on.
Later I will check about the --local flag

/assign @spiffxp @justaugustus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

the --project does not set the registry variable

Yep, see my second review: #21307 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants