Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blockade to kubernetes for pkg/util #21037

Merged
merged 1 commit into from
Feb 26, 2021
Merged

add blockade to kubernetes for pkg/util #21037

merged 1 commit into from
Feb 26, 2021

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Feb 26, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 26, 2021
@BenTheElder
Copy link
Member Author

/retest

BenTheElder
BenTheElder commented Feb 26, 2021
View reviewed changes
config/prow/plugins.yaml Outdated Show resolved Hide resolved
BenTheElder
BenTheElder commented Feb 26, 2021
View reviewed changes
config/prow/plugins.yaml
- kubernetes/kubernetes
blockregexps:
- ^pkg/util/[^/]+\.go$
explanation: "Utility code must be added to a subpackage like pkg/util/flag, not pkg/util directly. See: #49923"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/kubernetes#49923

spiffxp
spiffxp approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5e61459 into kubernetes:master Feb 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 26, 2021
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

/cc @spiffxp @dims @liggitt
one of the options for kubernetes/enhancements#2420 (comment) 4)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the blockade-util branch February 26, 2021 06:28
@BenTheElder BenTheElder mentioned this pull request Feb 26, 2021
Closed
12 tasks
@BenTheElder BenTheElder mentioned this pull request Feb 26, 2021
Merged
BenTheElder added a commit to BenTheElder/kubernetes that referenced this pull request Feb 26, 2021
@BenTheElder
drop obsolete verify-util-pkg.sh
1229665 
kubernetes/test-infra#21037 obsoletes this
jingxu97 pushed a commit to jingxu97/kubernetes that referenced this pull request Mar 3, 2021
@BenTheElder @jingxu97
drop obsolete verify-util-pkg.sh
7f67ee2 
kubernetes/test-infra#21037 obsoletes this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @spiffxp