Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add test for testrgrid alert emails on release-blocking jobs" #19907

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Revert "Add test for testrgrid alert emails on release-blocking jobs" #19907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions config/tests/jobs/jobs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,13 +969,6 @@ func verifyPodQOSGuaranteed(spec *coreapi.PodSpec) (errs []error) {
return errs
}

func hasAlertEmails(job cfg.JobBase) bool {
if _, ok := job.Annotations["testgrid-alert-email"]; !ok {
return false
}
return true
}

// A job is merge-blocking if it:
// - is not optional
// - reports (aka does not skip reporting)
Expand Down Expand Up @@ -1025,19 +1018,6 @@ func TestKubernetesReleaseBlockingJobsMustHavePodQOSGuaranteed(t *testing.T) {
}
}

// TODO: s/Should/Must and s/Logf/Errorf when all jobs pass
func TestKubernetesReleaseBlockingJobsMustHaveContactInformation(t *testing.T) {
for _, job := range allStaticJobs() {
// Only consider Pods that are release-blocking
if job.Spec == nil || !isKubernetesReleaseBlocking(job) {
continue
}
if !hasAlertEmails(job) {
t.Logf("%v: should have testgrid-alert-email(s)", job.Name)
}
}
}

// TODO: may need to rewrite to handle nodepools or handle jobs that can't be
// migrated over for a while
// TODO: s/Should/Must and s/Logf/Errorf when all jobs pass
Expand Down