Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring gcloud apis up to date for kettle #19783

Merged
merged 6 commits into from
Nov 5, 2020

Conversation

MushuEE
Copy link
Contributor

@MushuEE MushuEE commented Oct 30, 2020

*This still needs testing in staging

Kettle google-cloud packages are severely out of date and there are some methods that have changed/vanished. It will only be come increasingly painful to maintain so proactive updates seems appropriate.

/area kettle
/hold full test
#19358

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@MushuEE
Copy link
Contributor Author

MushuEE commented Oct 31, 2020

References...
BQ API for insert_rows - This seems to auto handle the schemas now.
BQ API change List for where everything is
BQ pubsub API
BQ client Code

@MushuEE
Copy link
Contributor Author

MushuEE commented Oct 31, 2020

At the point that everything feels correct, however pulling data from the database seems to be not working. I am unsure how it is populated in the test and it is quite confusing

@MushuEE
Copy link
Contributor Author

MushuEE commented Oct 31, 2020

@spiffxp @amwat This was pretty miserable change... and it was pretty hard to validate some of the new API functionality. I will test in staging this weekend.

@MushuEE
Copy link
Contributor Author

MushuEE commented Nov 4, 2020

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 4, 2020
@MushuEE MushuEE changed the title Bring gcloud apis up to date for kettle (WIP) Bring gcloud apis up to date for kettle Nov 4, 2020
@MushuEE
Copy link
Contributor Author

MushuEE commented Nov 4, 2020

Tested in staging

root@kettle-staging-56664586d8-7ggpq:/kettle# python3 stream.py --poll kubernetes-jenkins/gcs-changes/kettle   --dataset k8s-gubernator:build --tables staging:0 --stop_at=1

==== 2020-11-03 17:48:38 PST ========================================
PULLED 246
ACK irrelevant 245
EXTEND-ACK  1

/hold cancel
@spiffxp @amwat

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MushuEE, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0384172 into kubernetes:master Nov 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants