-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring gcloud apis up to date for kettle #19783
Conversation
Lots of complicated refactoring
References... |
At the point that everything feels correct, however pulling data from the database seems to be not working. I am unsure how it is populated in the test and it is quite confusing |
/label tide/merge-method-squash |
Tested in staging
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MushuEE, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
*This still needs testing in staging
Kettle google-cloud packages are severely out of date and there are some methods that have changed/vanished. It will only be come increasingly painful to maintain so proactive updates seems appropriate.
/area kettle
/hold full test
#19358