-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create ci-kubernetes-build-fast canary job to validate job running in the cluster #19487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be modified to push to gs://k8s-release-dev instead of gs://kubernetes-release-dev
I'm not sure off the top of my head which flag needs to be set where for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes as well
@spiffxp thanks for your review and input! I will check how to change that and apply here. |
@spiffxp done, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
I'm going to assume you've got the flag correct. This will need changes before we can start moving forward, but I'll merge this to get early signal.
- -- | ||
- --allow-dup | ||
- --fast | ||
- --release=k8s-release-dev/ci-canary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this as-is just to see if the job runs successfully, but for followup this should be different bucket / same path. I think what you have here is different bucket / different path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, followup PR: #19518
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cpanato: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
create duplicate
ci-kubernetes-build-fast
to run in thek8s-infra-prow-build
cluster to validate the execution buildref: #19484 and kubernetes/kubernetes#95173
/cc @spiffxp Dont know if there is anything else that we need to change, but this is an initial PR, let me know if this is correct.