Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config and references to kubernetes-incubator #19409

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

cblecker
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync area/prow Issues or PRs related to prow area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/velodrome sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 30, 2020
@cblecker
Copy link
Member Author

/assign @spiffxp

@nikhita
Copy link
Member

nikhita commented Sep 30, 2020

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2020
@cblecker
Copy link
Member Author

/hold cancel
Test are passing, and this can be merged as soon as it's approved.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2020
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2e216e4 into kubernetes:master Sep 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 30, 2020
@k8s-ci-robot
Copy link
Contributor

@cblecker: Updated the following 3 configmaps:

  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key fejta-bot-periodics.yaml using file config/jobs/kubernetes/test-infra/fejta-bot-periodics.yaml
    • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml
  • config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml
  • plugins configmap in namespace default at cluster test-infra-trusted using the following files:
    • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

ref kubernetes/community#1922

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker cblecker deleted the death-to-incubator branch September 30, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/label_sync Issues or PRs related to code in /label_sync area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow area/velodrome cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants