Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to include row_from_mapping changes released with 0.27.0 #19356

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

MushuEE
Copy link
Contributor

@MushuEE MushuEE commented Sep 24, 2020

googleapis/google-cloud-python#3874

I had made a change to use this attr but did not realize how were were pinning versions at the time because I tested locally and not in container env

Traceback (most recent call last):
  File "stream.py", line 300, in <module>
    stop=StopWhen(OPTIONS.stop_at))
  File "stream.py", line 202, in main
    emitted = insert_data(table, make_json.make_rows(db, builds))
  File "stream.py", line 123, in insert_data
    row = table.row_from_mapping(row)
AttributeError: 'Table' object has no attribute ‘row_from_mapping'

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kettle labels Sep 24, 2020
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2020
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MushuEE, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 993a255 into kubernetes:master Sep 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants