Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ingress-nginx jobs to use promoted images #19133

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Update ingress-nginx jobs to use promoted images #19133

merged 1 commit into from
Sep 8, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 4, 2020

Also, add a new Job to test against k8s v1.19.0

xref: kubernetes/ingress-nginx#6123

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 4, 2020
@aledbf
Copy link
Member Author

aledbf commented Sep 4, 2020

/assign @MrHohn

MrHohn
MrHohn approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@aledbf
Copy link
Member Author

aledbf commented Sep 8, 2020

@MrHohn thanks!

@k8s-ci-robot k8s-ci-robot merged commit 9b4e473 into kubernetes:master Sep 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 8, 2020
@k8s-ci-robot
Copy link
Contributor

@aledbf: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key ingress-nginx.yaml using file config/jobs/kubernetes/sig-network/ingress-nginx.yaml

In response to this:

Also, add a new Job to test against k8s v1.19.0

xref: kubernetes/ingress-nginx#6123

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf aledbf deleted the ingress branch December 29, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

@jingax10 jingax10 Awaiting requested review from jingax10

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @k8s-ci-robot @MrHohn