Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pull-kubernetes-bazel-build-canary to k8s-infra-prow-build #19077

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Move pull-kubernetes-bazel-build-canary to k8s-infra-prow-build #19077

merged 1 commit into from
Sep 1, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 31, 2020

Updated formatting to match pull-kubernetes-bazel-build, then
dropped the flag for RBE. Matched the resources of the RBE job,
we'll find out what's actually needed via this job

Part of #19073
The bazel build equivalent of #19069

@spiffxp
Move pull-kubernetes-bazel-build-canary to k8s-infra-prow-build
a424bb1 
Updated formatting to match pull-kubernetes-bazel-build, then
dropped the flag for RBE. Matched the resources of the RBE job,
we'll find out what's actually needed via this job
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 31, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 31, 2020

FYI @kubernetes/ci-signal

@spiffxp
Copy link
Member Author

spiffxp commented Aug 31, 2020

/hold
This is going to depend on #19076 merging

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Sep 1, 2020

/hold cancel
OK, this doesn't trip TestK8sInfraProwBuildJobsMustNotExceedTotalCapacity on its own, it can safely merge in batch with #19076

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
hasheddan
hasheddan approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d83dbcb into kubernetes:master Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubetest-canaries.yaml using file config/jobs/kubernetes/sig-testing/kubetest-canaries.yaml

In response to this:

Updated formatting to match pull-kubernetes-bazel-build, then
dropped the flag for RBE. Matched the resources of the RBE job,
we'll find out what's actually needed via this job

Part of #19073
The bazel build equivalent of #19069

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the mv-pull-bazel-build-canary-to-k8s-infra branch September 1, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan