Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give k8s-infra-prow-build cluster time to scale-up #18637

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Give k8s-infra-prow-build cluster time to scale-up #18637

merged 1 commit into from
Aug 4, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 4, 2020 •
edited
Loading

We have k8s-infra-prow-build setup to autoscale if it doen't have enough capacity. Anecdotally I saw it take 5sec to decide that it needed to scale, but another ~2min for a node to come online. Unfortunately plank deleted the pod after 1min, so we never got to benefit from the added capacity.

Let's assume it could take longer to scale up, so wait up to 5min before calling an unscheduled pod safe to delete.

This is based on investigation I did for period-kubernetes-bazel-test-canary refusing to schedule, ref: #18607 (comment)

@spiffxp
Give k8s-infra-prow-build cluster time to scale-up
c0ca18b 
We have k8s-infra-prow-build etup to autoscale if it doen't have
enough capacity. Anecdotally I saw it take 5sec to decide that
it needed to scale, but another ~2min for a node to come online.

Let's assume it could take longer, so wait up to 5min before calling
an unscheduled pod safe to delete.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 4, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 4, 2020

/cc @BenTheElder @hasheddan
I think this may improve some Pod scheduling timeout woes in general

/cc @chases2
FYI as test-infra oncall

@spiffxp spiffxp mentioned this pull request Aug 4, 2020
Merged
hasheddan
hasheddan approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @spiffxp!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Aug 4, 2020

/wg k8s-infra

@spiffxp
Copy link
Member Author

spiffxp commented Aug 4, 2020

This should help with migrate release-blocking jobs to k8s-infra-prow-build (#18549) and especially help with merge-blocking #18550

@k8s-ci-robot k8s-ci-robot merged commit bdabd60 into kubernetes:master Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/prow/config.yaml

In response to this:

We have k8s-infra-prow-build setup to autoscale if it doen't have enough capacity. Anecdotally I saw it take 5sec to decide that it needed to scale, but another ~2min for a node to come online. Unfortunately plank deleted the pod after 1min, so we never got to benefit from the added capacity.

Let's assume it could take longer to scale up, so wait up to 5min before calling an unscheduled pod safe to delete.

This is based on investigation I did for period-kubernetes-bazel-test-canary refusing to schedule, ref: #18607 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the good-nodes-come-to-those-who-wait branch August 4, 2020 01:32
@spiffxp
Copy link
Member Author

spiffxp commented Aug 4, 2020

The job I did this for hasn't failed due to pod scheduling timeout since this landed https://testgrid.k8s.io/sig-testing-canaries#bazel-test&width=20

@spiffxp
Copy link
Member Author

spiffxp commented Aug 4, 2020

I think this has taken care of #18507

@spiffxp spiffxp mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan