Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boskos pool dashboard to support same type, different instance #17724

Merged
merged 1 commit into from
May 28, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 27, 2020

I would like to have pools named identically across prow-builds' boksos
and k8s-infra's boskos, so there's one less thing to change when
migrating a prowjob from one build cluster to the other.

k8s-infra-gce-project vs. gce-project was a mistake I'd like to undo

I also want to be able to display a panel per-instance for the same pool
type. This is the dumb hardcoded approach

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2020
@spiffxp
Copy link
Member Author

spiffxp commented May 27, 2020

I added 5 projects to the k8s-infra boskos instance ref: kubernetes/k8s.io#898

Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.
One alternative/improvement to consider would be making the instance a template variable to avoid hardcoding and make it easy to filter the list of graphs by instance (e.g. this dashboard).
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I would like to have pools named identically across prow-builds' boksos
and k8s-infra's boskos, so there's one less thing to change when
migrating a prowjob from one build cluster to the other.

k8s-infra-gce-project vs. gce-project was a mistake I'd like to undo

I also want to be able to display a panel per-instance for the same pool
type. This is the dumb hardcoded approach
@spiffxp spiffxp force-pushed the boskos-pool-per-instance branch from 98962f9 to fbd0cba Compare May 27, 2020 22:47
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@spiffxp
Copy link
Member Author

spiffxp commented May 27, 2020

making the instance a template variable to avoid hardcoding

I agree, but I'd like the "all" option to enumerate dashboards, instead of aggregate. I think there's value in seeing one pool go down and the other go up side-by-side. I'll work on getting a setup where I can dev/test this locally. And I'll need to migrate k8s-infra-gce-project into gce-project.

@BenTheElder
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2020
@spiffxp
Copy link
Member Author

spiffxp commented May 28, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 632766c into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 28, 2020
@spiffxp spiffxp deleted the boskos-pool-per-instance branch May 28, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants