Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ServiceCatalog tests against latest k8s version #17622

Merged
merged 1 commit into from
May 20, 2020
Merged

Add ServiceCatalog tests against latest k8s version #17622

merged 1 commit into from
May 20, 2020

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented May 18, 2020 •
edited
Loading

Description

Add tests against 3 latest k8s versions.

Connected PR: kubernetes-retired/service-catalog#2803

Related Issue:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 18, 2020
@piotrmiskiewicz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8547d0b into kubernetes:master May 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 20, 2020
@k8s-ci-robot
Copy link
Contributor

@mszostok: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key service-catalog-presubmits.yaml using file config/jobs/kubernetes-sigs/service-catalog/service-catalog-presubmits.yaml

In response to this:

Description

Add tests against 3 latest k8s versions.

Connected PR: kubernetes-retired/service-catalog#2803

Related Issue:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mszostok mszostok deleted the test-sc-againt-k8s-matrix branch May 20, 2020 13:12
@mszostok mszostok mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@MHBauer MHBauer Awaiting requested review from MHBauer

Assignees

@piotrmiskiewicz piotrmiskiewicz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@mszostok @k8s-ci-robot @piotrmiskiewicz