Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: Loosen blockade regex on kubernetes/release repo #17013

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Mar 30, 2020

Since the blockade was initiated, we've migrated several of the
blockaded tools over to go and added tests for them
.

This also fixes a bug where the blockade was being triggered
unintentionally in subdirectories (like images/build/cross) because
the regex was not properly grouped (^foo|bar|baz as opposed to
^(foo|bar|baz).

Signed-off-by: Stephen Augustus [email protected]

/assign @cblecker @BenTheElder
cc: @kubernetes/release-engineering
cc: @liggitt (ref: kubernetes/release#1208 (comment))
ref: kubernetes/release#816

Since the blockade was initiated, we've migrated several of the
blockaded tools over to go and added tests for them.

This also fixes a bug where the blockade was being triggered
unintentionally in subdirectories (like 'images/build/cross') because
the regex was not properly grouped ('^foo|bar|baz' as opposed to
'^(foo|bar|baz)'.

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 30, 2020
@cblecker
Copy link
Member

/approve
LGTM to releng

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@idealhack
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit ab00878 into kubernetes:master Mar 31, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the plugins configmap in namespace default at cluster default using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Since the blockade was initiated, we've migrated several of the
blockaded tools over to go and added tests for them
.

This also fixes a bug where the blockade was being triggered
unintentionally in subdirectories (like images/build/cross) because
the regex was not properly grouped (^foo|bar|baz as opposed to
^(foo|bar|baz).

Signed-off-by: Stephen Augustus [email protected]

/assign @cblecker @BenTheElder
cc: @kubernetes/release-engineering
cc: @liggitt (ref: kubernetes/release#1208 (comment))
ref: kubernetes/release#816

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants