Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update periodic job definitions of ephemeral volumes 1-node test cases #13544

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Update periodic job definitions of ephemeral volumes 1-node test cases #13544

merged 1 commit into from
Jul 23, 2019

Conversation

mucahitkurt
Copy link
Contributor

@mucahitkurt mucahitkurt commented Jul 22, 2019 •
edited
Loading

Depends on PR: kubernetes/perf-tests#662
Related Comment: kubernetes/perf-tests#662 (comment)

Only existing job definitions are updated to new path of volume types, new job definitions will be added for cluster wide ephemeral volume performance test cases with a different PR, I need support for the parameters of new job definition(s).

/sig storage
/sig scalability
/assign @wojtek-t
cc @msau42

@mucahitkurt
update periodic job definitions of ephemeral volumes test cases which…
6f8455e 
… are running on 1-node cluster and add periodic job definitions of ephemeral volumes test cases which are running on cluster wide

Signed-off-by: Mucahit Kurt <[email protected]>
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mucahitkurt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2019
@k8s-ci-robot k8s-ci-robot requested review from mborsz and shyamjvs July 22, 2019 20:28
@mucahitkurt mucahitkurt mentioned this pull request Jul 22, 2019
Merged
@wojtek-t
Copy link
Member

/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d2994eb936568f9d1e1f7a55c1cdaff2cd718919

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mucahitkurt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2c3def5 into kubernetes:master Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

@mucahitkurt: Updated the job-config configmap in namespace default using the following files:

  • key sig-scalability-experimental-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml

In response to this:

Depends on PR: kubernetes/perf-tests#662
Related Comment: kubernetes/perf-tests#662 (comment)

Only existing job definitions are updated to new path of volume types, new job definitions will be added for cluster wide ephemeral volume performance test cases, I need support for the parameters of new job definition(s).

/sig storage
/sig scalability
/assign @wojtek-t
cc @msau42

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mucahitkurt
Copy link
Contributor Author

@wojtek-t I thought that I can add periodic job definitions of cluster wide test cases in this PR, but it's ok otherwise existing tests would break, I can open another PR for new job definitions. Thanks!

@mucahitkurt mucahitkurt changed the title Add periodic job definitions of ephemeral volumes cluster wide test cases Update periodic job definitions of ephemeral volumes 1-node test cases Jul 23, 2019
@wojtek-t
Copy link
Member

@wojtek-t I thought that I can add periodic job definitions of cluster wide test cases in this PR, but it's ok otherwise existing tests would break, I can open another PR for new job definitions. Thanks!

It's better to do that in a separate PR.

@mucahitkurt mucahitkurt deleted the scalability/storage/add-periodic-jobs-for-ephemeral-volumes-cluster-wide-perf-tests branch July 24, 2019 17:40
@mucahitkurt mucahitkurt mentioned this pull request Sep 7, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mucahitkurt @k8s-ci-robot @wojtek-t