Partially remove the default for --cookie-secret-file. #13521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Katharine
force-pushed
the
semi-default-cookie-secret
branch
from
42103f7 to
fe2b871
Compare
Katharine
force-pushed
the
semi-default-cookie-secret
branch
from
e98e1c7 to
b3356c1
Compare
stevekuznetsov
approved these changes
Jul 19, 2019
|
LGTM label has been added. Git tree hash: cb3753cbfd16fbfb978479b81a9c3b59453aae57
|
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Katharine, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code added to deck in #13323 assumes that
--cookie-secret-fileis either set to a file that exists or not set at all. This is not the case - the default is/etc/cookie/secret, but unless you set a different flag nothing ever checked that it existed until now. The result is deck crashing on startup trying to read a file that doesn't exist.This PR removes the default. However, for backwards compatibility, if it is not set, and the flag depending on it is set, and a file exists at the old default location, we use the default, emit an error message, and continue silently.
/cc @stevekuznetsov @fejta