Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pull-cluster-api-bazel-verify job #11642

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Remove pull-cluster-api-bazel-verify job #11642

merged 1 commit into from
Mar 6, 2019

Conversation

figo
Copy link
Contributor

@figo figo commented Mar 5, 2019 •
edited
Loading

  1. remove job: pull-cluster-api-bazel-verify
    pull-cluster-api-bazel-verify is only calling ./hack/verify-bazel.sh which already covered
    by pull-cluster-api-test job (it actually calling verify-bazel.sh, verify_clientset.sh etc).

  2. update job: pull-cluster-api-test with e2e image (bazel is needed)
    otherwise, you will see log (./hack/verify-bazel.sh Bazel not available, skipping validation) in current job, https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_cluster-api/805/pull-cluster-api-test/1724/build-log.txt

cc @BenTheElder @vincepri @detiber

@figo
Remove pull-cluster-api-bazel-verify job
4baac63 
also update pull-cluster-api-bazel-test job
with e2e image (bazel is needed)

pull-cluster-api-bazel-verify is only calling
./hack/verify-bazel.sh which already covered
by pull-cluster-api-bazel-test job (it actually
call both verify-bazel.sh and verify_clientset.sh etc).
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 5, 2019
@figo figo mentioned this pull request Mar 5, 2019
Merged
@BenTheElder
Copy link
Member

/assign @vincepri
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, figo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@detiber
Copy link
Member

detiber commented Mar 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fa426442f184191aa532838ee44045cf0817303

@k8s-ci-robot k8s-ci-robot merged commit c02ee04 into kubernetes:master Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

@figo: Updated the job-config configmap in namespace default using the following files:

  • key cluster-api-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml

In response to this:

  1. remove job: pull-cluster-api-bazel-verify
    pull-cluster-api-bazel-verify is only calling ./hack/verify-bazel.sh which already covered
    by pull-cluster-api-test job (it actually calling verify-bazel.sh, verify_clientset.sh etc).

  2. update job: pull-cluster-api-test with e2e image (bazel is needed)
    otherwise, you will see log (./hack/verify-bazel.sh Bazel not available, skipping validation) in current job, https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/sigs.k8s.io_cluster-api/805/pull-cluster-api-test/1724/build-log.txt

cc @BenTheElder @vincepri @detiber

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot mentioned this pull request Mar 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@detiber detiber

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@figo @BenTheElder @k8s-ci-robot @detiber @vincepri