Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aws credentials file uniformly named #10866

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Make aws credentials file uniformly named #10866

merged 1 commit into from
Jan 22, 2019

Conversation

shyamjvs
Copy link
Member

This is the name also used by the aws-sdk.

/cc @gyuho @krzyzacy

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jenkins area/prow Issues or PRs related to prow area/scenarios sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2019
@gyuho
Copy link
Member

gyuho commented Jan 21, 2019

/lgtm
/cc @krzyzacy

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7270a60f644ff4d0c078fe1108247c90a1890f9d

@shyamjvs
Copy link
Member Author

FYI - This will allow using different testing accounts for kops/eks tests (by just varying the preset). I'll send a follow-up PR soon.

@shyamjvs shyamjvs mentioned this pull request Jan 21, 2019
Merged
BenTheElder
BenTheElder reviewed Jan 22, 2019
View reviewed changes
experiment/bootstrap/main.go
@@ -30,8 +30,8 @@ const (
CloudSDKEnv string = "CLOUDSDK_CONFIG"
GCEPrivKeyEnv string = "JENKINS_GCE_SSH_PRIVATE_KEY_FILE"
GCEPubKeyEnv string = "JENKINS_GCE_SSH_PUBLIC_KEY_FILE"
AWSPrivKeyEnv string = "JENKINS_AWS_SSH_PRIVATE_KEY_FILE"
AWSPubKeyEnv string = "JENKINS_AWS_SSH_PUBLIC_KEY_FILE"
AWSPrivKeyEnv string = "AWS_SSH_PRIVATE_KEY_FILE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh reminder to myself delete this experiment. we're definitely not going this route

BenTheElder
BenTheElder approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
mind if we merge this tomorrow when more people are around to keep an eye on any breakage?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2019
@shyamjvs
Copy link
Member Author

Sure.

@krzyzacy
Copy link
Member

Ummm, who's consuming these envs downstream? Seems not in test-infra? cc @justinsb who might know?

@shyamjvs
Copy link
Member Author

@krzyzacy AWS SDK uses it (see vendor).

@shyamjvs
Copy link
Member Author

@BenTheElder Can we cancel hold now?

@BenTheElder
Copy link
Member

BenTheElder commented Jan 22, 2019 via email

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit aa8d6d1 into kubernetes:master Jan 22, 2019
@k8s-ci-robot
Copy link
Contributor

@shyamjvs: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

This is the name also used by the aws-sdk.

/cc @gyuho @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shyamjvs shyamjvs deleted the uniform-aws-credentials branch January 22, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@gyuho gyuho Awaiting requested review from gyuho

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

@gyuho gyuho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jenkins area/prow Issues or PRs related to prow area/scenarios cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shyamjvs @gyuho @k8s-ci-robot @krzyzacy @BenTheElder