Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bazel-verify step to sigs.k8s.io/cluster-api #10725

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Add bazel-verify step to sigs.k8s.io/cluster-api #10725

merged 1 commit into from
Jan 16, 2019

Conversation

vincepri
Copy link
Member

Signed-off-by: Vince Prignano [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2019
@k8s-ci-robot k8s-ci-robot requested review from karan and spiffxp January 12, 2019 02:07
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 12, 2019
@vincepri
Copy link
Member Author

Related to kubernetes-sigs/cluster-api#43

@vincepri
Copy link
Member Author

/assign @roberthbailey

BenTheElder
BenTheElder approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2019
BenTheElder
BenTheElder reviewed Jan 12, 2019
View reviewed changes
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml
- "--repo=sigs.k8s.io/$(REPO_NAME)=$(PULL_REFS)"
- "--root=/go/src"
- "--upload=gs://kubernetes-jenkins/pr-logs"
- "--scenario=execute"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: execute scenario jobs should eventually move to the pod-utils instead, it's less config!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. We already do this in cluster-api-provider-aws, need to open an issue to track this.

@vincepri
Copy link
Member Author

/test pull-test-infra-bazel

@roberthbailey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad21ddeef6cb1edeff5f7487ea3b46617d46a3d8

BenTheElder
BenTheElder reviewed Jan 16, 2019
View reviewed changes
testgrid/config.yaml
@@ -2445,6 +2445,9 @@ test_groups:
gcs_prefix: kubernetes-jenkins/pr-logs/directory/pull-org-verify-all
num_columns_recent: 30
#presubmits
- name: pull-cluster-api-bazel-verify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be added to one of the dashboards (cluster lifecycle?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done : )

@vincepri vincepri force-pushed the cluster-api-bazel-verify branch from 0675087 to 8aad940 Compare January 16, 2019 21:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2019
BenTheElder
BenTheElder approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe7f21d6bc78a17a029c9b7c28ac89cb970a63d8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fc23403 into kubernetes:master Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

@vincepri: Updated the job-config configmap using the following files:

  • key cluster-api-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml

In response to this:

Signed-off-by: Vince Prignano [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@karan karan Awaiting requested review from karan

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincepri @roberthbailey @k8s-ci-robot @BenTheElder